Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Incognito to Tor for download warning message #5369

Open
srirambv opened this issue Jul 24, 2019 · 2 comments
Open

Replace Incognito to Tor for download warning message #5369

srirambv opened this issue Jul 24, 2019 · 2 comments
Labels
feature/tor feature/user-interface All UI related needs-text-change This change requires some careful wording. priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Replace Incognito to Tor for download warning message

Steps to Reproduce

  1. Download a file in Tor window
  2. Close the window while download is in progress
  3. Warning message shows Incognito instead of Tor

Actual result:

image

Expected result:

Proper naming convention to be used for specific window types

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Revision 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@srirambv srirambv added feature/user-interface All UI related priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude labels Jul 24, 2019
@kjozwiak
Copy link
Member

Looks like macOS uses Quit private mode anyway?

Screen Shot 2019-07-24 at 11 50 17 AM

We need to use the same wording across the different platforms. I'm not sure if Quit private mode is correct or it should mention Quit Tor mode as @srirambv mentioned above.

@tildelowengrimm
Copy link
Contributor

Text should be

Closing this private window with Tor will cancel this download.
[Continue download] [Cancel download and exit]

@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/tor feature/user-interface All UI related needs-text-change This change requires some careful wording. priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

4 participants