Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements not blocked by selector when tab loaded in background #5215

Closed
wooque opened this issue Jul 11, 2019 · 1 comment · Fixed by brave/brave-core#3121
Closed

Elements not blocked by selector when tab loaded in background #5215

wooque opened this issue Jul 11, 2019 · 1 comment · Fixed by brave/brave-core#3121

Comments

@wooque
Copy link

wooque commented Jul 11, 2019

Description

Elements that are blocked by selector are blocked if tab is loaded in current tab, but not if tab is loaded in background.

Steps to Reproduce

  1. Block any element via selector on any page
  2. Bookmark page
  3. Open that bookmark with 'Open link in new tab'

[more detailed STR in https://github.com/brave/brave-core/pull/3121]

Actual result:

Element not blocked when tab opened in background

Expected result:

Element blocked

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build)unknown (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? /
@btlechowski
Copy link

btlechowski commented Sep 26, 2019

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Reproduced the issue in 0.68.141.
Verified test plan from brave/brave-core#3121

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants