Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User wallet: Protocol changes (Tips) #4776

Closed
mandar-brave opened this issue Jun 10, 2019 · 1 comment · Fixed by brave/brave-core#2696
Closed

User wallet: Protocol changes (Tips) #4776

mandar-brave opened this issue Jun 10, 2019 · 1 comment · Fixed by brave/brave-core#2696

Comments

@mandar-brave
Copy link

Cross referencing: #4775

User wallets -> Tips has a protocol change per TOS;
a) 95% of the payment will go the publishers
b) 5% of the payment will go to the settlement wallet as the fee

@evq for protocol specific changes.
@alexwykoff

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 10, 2019
@mandar-brave mandar-brave added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 24, 2019
@NejcZdovc NejcZdovc self-assigned this Jul 8, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Nightly milestone Jul 8, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Sep 3, 2019

Verified passed with

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • Verified test plan from Uphold wallet brave-core#2696
  • Verified this is what shows in uphold when tipping from Verified/KYC'd account (95/5% split):
    Screen Shot 2019-09-03 at 5 16 12 PM
  • Verified still able to tip if you never connect to uphold at all and tip from anon Brave wallet.
  • Verified able to tip if you had BAT in your anon wallet and then connected a non-KYC'd Uphold account (note, this could be funded with crypto as allowable by local laws). BAT in anon wallet is used prior to any BAT in the Brave Browser card.

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • Verified test plan from Uphold wallet brave-core#2696
  • Verified this is what shows in uphold when tipping from Verified/KYC'd account (95/5% split):
    image
  • Verified still able to tip if you never connect to uphold at all and tip from anon Brave wallet.
  • Verified able to tip if you had BAT in your anon wallet and then connected a non-KYC'd Uphold account (note, this could be funded with crypto as allowable by local laws). BAT in anon wallet is used prior to any BAT in the Brave Browser card.

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified test plan from Uphold wallet brave-core#2696
  • Verified this is what shows in uphold when tipping from Verified/KYC'd account (95/5% split):

image

  • Verified still able to tip if you never connect to uphold at all and tip from anon Brave wallet.
  • Verified able to tip if you had BAT in your anon wallet and then connected a non-KYC'd Uphold account (note, this could be funded with crypto as allowable by local laws). BAT in anon wallet is used prior to any BAT in the Brave Browser card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants