Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User wallet: Uphold Connect #4774

Closed
mandar-brave opened this issue Jun 10, 2019 · 3 comments · Fixed by brave/brave-core#2696
Closed

Add User wallet: Uphold Connect #4774

mandar-brave opened this issue Jun 10, 2019 · 3 comments · Fixed by brave/brave-core#2696

Comments

@mandar-brave
Copy link

Build a browser side user claim wallet using existing Uphold Connect functionality on Brave Rewards.

States:

  • Brave Rewards default state (uni directional wallet)
  • Uphold Connected + Unverified state (Uphold wallet but no KYC)
  • Uphold Connect + Verified state (Uphold wallet but KYC)
  • Uphold Disconnected - wallet token expired or was manually disconnected
  • Uphold Re-Authorize - wallet token needs re-auth to reset BAT limits for transfer

@alexwykoff
@jenn-rhim please update UI/UX for these states.

@mandar-brave mandar-brave added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jun 10, 2019
@mandar-brave
Copy link
Author

image

The three operating states are defined above.
There are two states where Uphold will show disconnected;

a) when the auth_token has expired
b) when the BAT limits per transaction have been hit

When this happens;
image

Edit: considering the last state of the wallet when disconnected is irrelevant, the bottom area should be gray (like the default BR state)

@srirambv
Copy link
Contributor

@mandar-brave @jenn-rhim Can we use Re-authenticate instead of Reconnect? Reconnect would mean that the Uphold wallet is removed and needs to be readded which might be confusing. Re-authenticate is what is happening in the step not reconnecting

@mandar-brave mandar-brave added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 24, 2019
@NejcZdovc NejcZdovc self-assigned this Jul 8, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Nightly milestone Jul 8, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Sep 4, 2019

Verified passed with

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

1a. PASS Clean profile - Unconnected (never connected) - With 1a/1b, verified that if a user never follows the Verify Wallet flow to uphold and signs up or connects any account, they can still do the following:

  • Verified able to one time tip verified pubs, monthly tip verified pubs, and auto contribute to verified pubs.
  • Verified able to claim UGP grant by completing captcha.
  • Verified can claim ads earnings grant by completing captcha.
  • Verified unable to access old add funds UI.
  • Note, clean install had restored a previous anon wallet with BAT.

1b. PASS Upgrade profile - Unconnected (never connected):

  • Verified able to one time tip verified pubs, monthly tip verified pubs, and auto contribute to verified pubs.
  • Verified able to claim UGP grant by completing captcha.
  • Verified can claim ads earnings grant by completing captcha.
  • Verified unable to access old add funds UI.
  • Note - upgrade profile had BAT in anon wallet prior to "upgrade".

2a. PASS Clean profile - Connected, but not KYC'd - With 2a/2b, verify the following when a user follows Verify Wallet flow and signs up with Uphold but never kyc's or logs in to uphold with an account that is not KYC'd:

  • Verified any BAT in brave://rewards prior to connecting a non-KYC'd uphold account is NOT moved to your Brave Browser card in Uphold.
  • Verified able to add crypto only (not fund in any other way) in Uphold and balance updates accordingly in brave://rewards.
  • Verified tips, ac, etc are taken from the anon card (your existing BAT) before your Uphold BAT (Brave Browser card).
  • Verified able to one time tip verified pubs, monthly tip verified pubs, and auto contribute.
  • Verified able to claim UGP grant by completing captcha. UGP grant does not move to Brave Browser card.
  • Verified can claim ads earnings grant by completing captcha. Ad grant does not move to Brave Browser card.
  • Note, clean install had restored a previous anon wallet with BAT.

2b. PASS Upgrade profile - Connected, but not KYC'd:

  • Verified any BAT in brave://rewards prior to connecting a non-KYC'd uphold account is NOT moved to your Brave Browser card in Uphold.
  • Verified able to add crypto only (not fund in any other way) in Uphold and balance updates accordingly in brave://rewards.
  • Verified tips, ac, etc are taken from the anon card (your existing BAT) before your Uphold BAT (Brave Browser card).
  • Verified able to one time tip verified pubs, monthly tip verified pubs, and auto contribute.
  • Verified able to claim UGP grant by completing captcha. UGP grant does not move to Brave Browser card.
  • Verified can claim ads earnings grant by completing captcha. Ad grant does not move to Brave Browser card.
  • Note - upgrade profile had BAT in anon wallet prior to "upgrade".

3a. PASS Clean profile - Fully Verified/KYC'd - With 3a/3b, verify the following items when a user follows the Verify Wallet flow and KYC's with uphold/signs in with verified uphold account:

  • Verified any BAT in brave://rewards prior to connecting a KYC'd uphold account is moved to your Brave Browser card in Uphold.
  • Verified able to add funds in Uphold and balance updates in brave://rewards .
  • Verified able to one time tip verified pubs, monthly tip verified pubs, and auto contribute.
  • Verified able to claim UGP grant by completing captcha. UGP grant does not move to Brave Browser card.
  • Verified can claim ads earnings grant by completing captcha. Ad grant does not move to Brave Browser card (will in the future if you are KYC'd).
  • Note, clean install had restored a previous anon wallet with BAT.

3b. PASS Upgrade profile - Fully Verified/KYC'd:

  • Verified any BAT in brave://rewards prior to connecting a KYC'd uphold account is moved to your Brave Browser card in Uphold.
  • Verified able to add funds in Uphold and balance updates in brave://rewards .
  • Verified able to one time tip verified pubs, monthly tip verified pubs, and auto contribute.
  • Verified able to claim UGP grant by completing captcha. UGP grant does not move to Brave Browser card.
  • Verified can claim ads earnings grant by completing captcha. Ad grant does not move to Brave Browser card (will in the future if you are KYC'd).
  • Note - upgrade profile had BAT in anon wallet prior to "upgrade".

Verified UI for the various states:
Brave Rewards default state (uni directional wallet)
Screen Shot 2019-09-03 at 9 22 04 PM

Uphold Connected + Unverified state (Uphold wallet but no KYC)
Screen Shot 2019-09-04 at 6 05 42 PM

Uphold Connect + Verified state (Uphold wallet but KYC)
Screen Shot 2019-09-03 at 9 21 21 PM

Uphold Disconnected - wallet token expired or was manually disconnected
Screen Shot 2019-09-03 at 9 24 01 PM

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Brave Rewards default state (uni directional wallet)
image

Uphold Connected + Unverified state (Uphold wallet but no KYC)
image

Uphold Connect + Verified state (Uphold wallet but KYC)
image
Uphold Disconnected - wallet token expired or was manually disconnected
image

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verified UI for the various states:
Brave Rewards default state (unidirectional wallet)
image
Uphold Connected + Unverified state (Uphold wallet but no KYC)
image

Uphold Connect + Verified state (Uphold wallet but KYC)
image
Uphold Disconnected - wallet token expired or was manually disconnected
image

@rebron rebron changed the title User wallet: Uphold Connect Add User wallet: Uphold Connect Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants