Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoted tweet doesn't display the twitter card for our brave.com/tips landing page. #4605

Closed
jenn-rhim opened this issue May 24, 2019 · 3 comments

Comments

@jenn-rhim
Copy link

@mandar-brave

Actual result:

Difference of a tweet without a quote tweet and with one.

  1. Tip the twitter user from the BR panel
    Screen Shot 2019-05-24 at 2 38 35 PM

  2. Tip the tweet (tweet is quoted)
    Screen Shot 2019-05-24 at 2 38 24 PM

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@jenn-rhim jenn-rhim changed the title Quoted tweet doesn't display the twitter cards for our landing page. Quoted tweet doesn't display the twitter card for our landing page. May 24, 2019
@jenn-rhim jenn-rhim changed the title Quoted tweet doesn't display the twitter card for our landing page. Quoted tweet doesn't display the twitter card for our brave.com/tips landing page. May 24, 2019
@mandar-brave
Copy link

may be duplicate of #4597
@emerick @NejcZdovc

@emerick
Copy link
Contributor

emerick commented May 24, 2019

I think @jenn-rhim is saying she prefers the "tweet card" look of option 1 above. We're currently using the Twitter web intents API, which is fairly primitive so this would require some work.

https://developer.twitter.com/en/docs/twitter-for-websites/web-intents/overview.html

@NejcZdovc
Copy link
Contributor

closing as I don't see really what can be done here as @emerick said it intents are limited

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 10, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants