Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download checks for SafeBrowsing should go through Tor. #4290

Open
jumde opened this issue May 2, 2019 · 4 comments
Open

Download checks for SafeBrowsing should go through Tor. #4290

jumde opened this issue May 2, 2019 · 4 comments
Assignees
@fmarier
Labels
feature/safebrowsing feature/tor priority/P4 Planned work. We expect to get to it "soon".

Comments

@jumde
Copy link
Contributor

jumde commented May 2, 2019

We are disabling SafeBrowsing in Tor, since download checks are not going through Tor. Re-enable SafeBrowsing once the issue is addressed.
@jumde jumde mentioned this issue May 2, 2019
Closed
@riastradh-brave riastradh-brave self-assigned this May 3, 2019
@riastradh-brave riastradh-brave added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 6, 2019
@diracdeltas
Copy link
Member

note this is blocked on #4341 (making sure the sb download implementation is sufficiently private)

@diracdeltas diracdeltas added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels May 28, 2019
@fmarier fmarier self-assigned this Jul 19, 2022
@LaurenWags
Copy link
Member

I'm seeing a message to enable Safe Browsing when downloading from a Tor window, will that go away once this is issue is fixed?

Screenshot 2024-08-16 at 4 28 40 PM

Occurs with both 1.69.x (RC) and 1.68.x, so doesn't seem to be a new thing.

@fmarier
Copy link
Member

fmarier commented Aug 16, 2024

I'm seeing a message to enable Safe Browsing when downloading from a Tor window, will that go away once this is issue is fixed?

Maybe, but I think we should suppress that warning in the meantime and so that would be a meaningful issue to file.

@LaurenWags LaurenWags mentioned this issue Aug 19, 2024
Open
6 tasks
@LaurenWags
Copy link
Member

thanks @fmarier - logged #40529 for suppressing the warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
feature/safebrowsing feature/tor priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fmarier @diracdeltas @jumde @LaurenWags @riastradh-brave