Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: 1.71.123->1.73.89, text selection is not highlighted on Twitter/X. #42369

Closed
2 of 6 tasks
serjepatoff opened this issue Nov 19, 2024 · 4 comments
Closed
2 of 6 tasks
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. OS/Desktop webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@serjepatoff
Copy link

Description

Selection of edited text on Twitter/X, either in a post edit box or a comment edit box, is not highlighted.

Steps to reproduce

  1. Upgraded Brave from 1.71.123 to 1.73.89 on Arch Linux.
  2. Opened x.com, started writing a comment.
  3. When I tried to select currently edited text by using either mouse click-and-drag, or Shift+Left/Right buttons, or by pressing Ctrl-A, no highlight of selected text was visible. At the same time, selection actually worked: for example, pressing Ctrl-A, Backspace deleted all text.

Actual result

Selection of edited text on Twitter/X is not highlighted.

Expected result

Selection of edited text on Twitter/X should be highlighted.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Version 1.73.89 Chromium: 131.0.6778.69 (Official Build) (64-bit)
OS: Arch Linux
uname -a: Linux 6.6.62-1-lts #1 SMP PREEMPT_DYNAMIC Sun, 17 Nov 2024 16:35:16 +0000 x86_64 GNU/Linux

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

  1. This issue occured with Brave Shields both enabled or disabled
  2. Rolling back to 1.71.123 fixed this issue.
@unknownuserisknown
Copy link

Can confirm. I'm running Manjaro (Arch-based distro) and text selection highlighting does not appear in Brave Version 1.73.89 Chromium: 131.0.6778.69 (Official Build) (64-bit)]

@rebron
Copy link
Collaborator

rebron commented Nov 20, 2024

@serjepatoff @unknownuserisknown Can you update to 1.73.91? We just released and fix should be in this version.

@rebron rebron self-assigned this Nov 20, 2024
@rebron rebron added this to General Nov 20, 2024
@ShivanKaul ShivanKaul added webcompat/not-shields-related Sites are breaking because of something other than Shields. Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix labels Nov 20, 2024
@ShivanKaul
Copy link
Collaborator

Can confirm that 1.73.91 Chromium: 131.0.6778.85 on Brave Release fixes the issue. For reference, this is the upstream issue. Chromium fixed it by disabling the runtime flag HighlightInheritance in all channels. With the latest Chromium bump we've inherited the actual code change.

@github-project-automation github-project-automation bot moved this to Completed in General Nov 20, 2024
@ShivanKaul ShivanKaul added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Nov 20, 2024
@rebron rebron removed their assignment Nov 20, 2024
@unknownuserisknown
Copy link

I can also confirm the fix. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. OS/Desktop webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
Status: Completed
Development

No branches or pull requests

4 participants