Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - User cannot cancel history deletion #41148

Closed
3 of 5 tasks
Brandon-T opened this issue Sep 19, 2024 · 2 comments · Fixed by brave/brave-core#25652
Closed
3 of 5 tasks

[iOS] - User cannot cancel history deletion #41148

Brandon-T opened this issue Sep 19, 2024 · 2 comments · Fixed by brave/brave-core#25652
Assignees

Comments

@Brandon-T
Copy link

Description

  • Attempt to delete all history
  • No way to cancel the alert once it pops up.
    image

Steps to reproduce

  • Attempt to delete all history
  • No way to cancel the alert once it pops up.

Actual result

Cannot dismiss delete. Must kill the app.

Expected result

  • Should allow user to cancel deleting all history

Reproduces how often

Easily reproduced

Brave version

N/A

Device/iOS version

Any

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.71.116 or higher for 1.71.x verification 👍

@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18 using version 1.71.118

  • Ensured that Clear Browsing History dialog has option to cancel.
  • Ensured clearing history still works.
  • Ensured that tapping on Cancel will dismiss action and not delete.
example example
Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants