Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings sections should be better ordered for popularity and complexity #4108

Closed
petemill opened this issue Apr 15, 2019 · 1 comment · Fixed by brave/brave-core#2530
Closed
Assignees
Labels
feature/global-settings Settings at browser level independent of shields settings priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@petemill
Copy link
Member

petemill commented Apr 15, 2019

Test plan

  1. Visit brave://settings/
  2. Ensure menu items are ordered (per below)
  3. Ensure content area is ordered the same

Description

New order according to @bradleyrichter 👍

Getting started
Appearance
Sync
Shields
Social media blocking
Search engine
Extensions
@petemill petemill self-assigned this Apr 15, 2019
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. feature/global-settings Settings at browser level independent of shields settings labels Apr 16, 2019
@bsclifton bsclifton added this to the 0.68.x - Nightly milestone May 29, 2019
@btlechowski
Copy link

btlechowski commented Jul 24, 2019

Verification passed on

Brave 0.68.109 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Used test plan from brave/brave-core#2530
Checked if all the links work as expected.

image

Verification passed on

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verified passed with

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants