Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable New Playlist UI by default #40911

Closed
kylehickinson opened this issue Sep 6, 2024 · 2 comments · Fixed by brave/brave-core#25474
Closed

Enable New Playlist UI by default #40911

kylehickinson opened this issue Sep 6, 2024 · 2 comments · Fixed by brave/brave-core#25474

Comments

@kylehickinson
Copy link
Collaborator

Description

New Playlist UI will now be enabled by default, and should be fully tested.

Test Plan should be the same as normal Playlist tests, except the new playlist UI does not support shared playlists

Roadmap issues:
https://github.com/brave/roadmap/issues/1393
https://github.com/brave/roadmap/issues/1205

@kylehickinson kylehickinson added QA/Yes release-notes/include features/playlist OS/iOS Fixes related to iOS browser functionality labels Sep 6, 2024
@kylehickinson kylehickinson self-assigned this Sep 6, 2024
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Sep 9, 2024
@Uni-verse Uni-verse added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Test-All-Platforms labels Oct 18, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 18, 2024

Verified on iPhone 12 running iOS 18.0 using version 1.71.116

New Users

Test Cases Covered

  • feature flag
  • playlist tutorial
  • adding items
    • YouTube videos
    • Other media sites (X, Rumble, DailyMotion)
    • Audio/Sound only
  • opening in Playlist
    • via url bar
    • via share menu
    • via long press
    • siri shortcut on homescreen (shortcuts app)
  • deleting items
    • offline items
    • saved items
    • folders/playlists
  • creating playlists
  • saving offline
    • wifi
    • cellular
  • using with VPN
  • playlist controls
    • pip
    • full screen functions
    • background play
    • timer
    • edit mode
      • delete
      • move
    • long press functions
  • settings/preferences
    • autoplay (setting)
    • auto-save for offline (setting)
    • enable long press (setting)
    • web compatibility (setting)
  • misc.
    • opening playlist after re-launching Brave
    • ensure no issues after device restarts/device sleeps
    • enabling airplane mode
example example example example example
Image Image Image Image Image
Image Image Image Image Image

Existing Users

  • Ensured existing playlist were retained after upgrading and played successfully.
  • Ensured playlist settings were retained.
  • Ensured adding/deleting and moving items in playlist is working after upgrading.
  • Ensured new Playlist UI is shown after upgrading.
example example example example
Image Image Image Image

@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 21, 2024

Verified on iPad (7th Gen) running iOS 17.5.1 using version 1.71.118

New Users

Test Cases Covered

  • feature flag
  • playlist tutorial
  • adding items
    • YouTube videos
    • Other media sites (X, Rumble, DailyMotion)
    • Audio/Sound only
  • opening in Playlist
    • via url bar
    • via share menu
    • via long press
    • siri shortcut on homescreen (shortcuts app)
  • deleting items
    • offline items
    • saved items
    • folders/playlists
  • creating playlists
  • saving offline
    • wifi
    • cellular
  • using with VPN
  • playlist controls
    • pip
    • full screen functions
    • background play
    • timer
    • edit mode
      • delete
      • move
    • long press functions
  • settings/preferences
    • autoplay (setting)
    • auto-save for offline (setting)
    • enable long press (setting)
    • web compatibility (setting)
  • misc.
    • opening playlist after re-launching Brave
    • ensure no issues after device restarts/device sleeps
    • enabling airplane mode
example example example example example
Image Image Image Image Image
Image Image Image Image Image

Existing Users

  • Ensured existing playlist were retained after upgrading and played successfully.
  • Ensured playlist settings were retained.
  • Ensured adding/deleting and moving items in playlist is working after upgrading.
  • Ensured new Playlist UI is shown after upgrading.
example example
Image Image

@Uni-verse Uni-verse added QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants