Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider disabling lookalike url navigation observer #3942

Closed
jumde opened this issue Mar 29, 2019 · 6 comments
Closed

Consider disabling lookalike url navigation observer #3942

jumde opened this issue Mar 29, 2019 · 6 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@jumde
Copy link
Contributor

jumde commented Mar 29, 2019

Chromium enabled this feature by default: https://tech.slashdot.org/story/19/01/30/2020218/google-chrome-to-get-warnings-for-lookalike-urls

Can be annoying to users: https://community.brave.com/t/did-you-mean-to-go-to-all-of-a-sudden-displaying/50950/6

@Brave-Matt
Copy link

Support's two cents:
I think overall this feature is well-intentioned. This would be especially useful for Brave users given that many of them are involved in/browse cryptocurrency sites/exchanges which are notorious for these "lookalike" URLs. Having this feature implemented could save users from sites attempting to steal credentials for these sites.
If it's not sending network requests or compromising security, I think this is something that should be surfaced and included in Settings so that users have access to the feature but can also easily turn it off should it annoy them.

@weeblr
Copy link

weeblr commented Apr 1, 2019

User's two cents:

It's all fine and dandy until it's your own small business website that Chrome/Brave decides to send potential visitors away to a much bigger competitor.

If this really is a security feature, will there be some kind of whitelisting possible?

Best regards

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Apr 5, 2019
@Brave-Matt
Copy link

Yes, this is considered a security feature. Phishing is a real thing. There are several websites sites, especially those centered around Crypto, that warn you to ensure that you're on the site you believe to be:
image

@weeblr
Copy link

weeblr commented May 4, 2019

@Brave-Matt Well, if Brave tries to lures users willing to visit weeblr.com, a perfectly fine, secure and honest website, into thinking it's a bad site and strongly suggests to visit weebly.com instead, isn't Brave itself doing phishing now?

The problem here is that the selection of the "offending" site is not based on security. It's not based on whether the site is a phishing target. It's not based on anything but a simply similitude between the 2 names. And that's not enough. There's not even a place where we can go and ask to be removed from that list. Of course, we're not big enough to sue but I guess at some point someone will. I guess the people from vive.com won't like seeing their visitors suggested to go to live.com. But they're a big company so I guess they'll find a way.

It's not even based on trademark as our trademark actually pre-dates that of weebly in our trademark class.

@rebron rebron added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels May 4, 2019
@rebron
Copy link
Collaborator

rebron commented May 4, 2019

Looks well intentioned but it doesn't work even with a simple use case where a user going to vive.com is then directed to go to live.com.

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels May 5, 2019
@rebron
Copy link
Collaborator

rebron commented May 9, 2019

Closing. This is fixed with brave/brave-core#2382. In process to be uplifted to 64.x.

@rebron rebron closed this as completed May 9, 2019
@kjozwiak kjozwiak removed the priority/P2 A bad problem. We might uplift this to the next planned release. label May 10, 2019
@bsclifton bsclifton added closed/duplicate Issue has already been reported and removed closed/duplicate Issue has already been reported labels May 26, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

8 participants