Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download bar support Mojave dark mode #3912

Closed
levinunnink opened this issue Mar 27, 2019 · 1 comment
Closed

Download bar support Mojave dark mode #3912

levinunnink opened this issue Mar 27, 2019 · 1 comment
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@levinunnink
Copy link

levinunnink commented Mar 27, 2019 •
edited
Loading

Description

Download bar is illegible when in dark mode on macOS Mojave.

Steps to Reproduce

Download any file Brave

Expected result

The download bar should be readable.

Actual result

It appears that the color values in the download bar are hardcoded instead of using the dynamic system colors, like [NSColor controlTextColor].

Reproduces how often:

Every time.

Brave version (brave://version info)

  • Version 0.61.52 Chromium: 73.0.3683.86 (Official Build) (64-bit)
  • macOS 10.14.1 (18B75)
@simonhong
Copy link
Member

simonhong commented Mar 28, 2019 •
edited
Loading

Duplicated with #3708 and fixed since 0.62

@simonhong simonhong added the closed/duplicate Issue has already been reported label Mar 28, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@levinunnink @bbondy @simonhong @NejcZdovc