Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup wallet from menu loads brave://wallet/crypto/backup-wallet with Settings tab bar instead of the new onboarding flow #38640

Closed
2 of 6 tasks
srirambv opened this issue May 28, 2024 · 4 comments · Fixed by brave/brave-core#23872
Closed
2 of 6 tasks

Backup wallet from menu loads brave://wallet/crypto/backup-wallet with Settings tab bar instead of the new onboarding flow #38640

srirambv opened this issue May 28, 2024 · 4 comments · Fixed by brave/brave-core#23872
Assignees
@muliswilliam
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes regression release-notes/exclude
Milestone
1.67.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Backup wallet from menu loads brave://wallet/crypto/backup-wallet with Settings tab bar instead of the new onboarding flow

Steps to reproduce

  1. Create a new wallet or restore a wallet from seed
  2. Open Portfolio menu and click on Backup now
  3. Loads brave://wallet/crypto/backup-wallet
  4. Try to click on settings tab strip doesn't work

Actual result

Backup.Wallet.from.Menu.mp4

Expected result

Should navigate to brave://wallet/crypto/onboarding/new/explain-recovery-phrase instead of brave://wallet/crypto/backup-wallet

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.67.98 Chromium: 125.0.6422.112 (Official Build) beta (64-bit)
Revision 9434daa5e8d2aceabb9cce574ab39429f2923b9b
OS Windows 11 Version 23H2 (Build 22631.3593)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @muliswilliam
@srirambv srirambv added this to Web3 May 28, 2024
@srirambv srirambv mentioned this issue May 28, 2024
Closed
@muliswilliam muliswilliam mentioned this issue May 28, 2024
Merged
24 tasks
@muliswilliam muliswilliam self-assigned this May 28, 2024
@muliswilliam muliswilliam moved this to In Review in Web3 May 28, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 May 28, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 28, 2024
@muliswilliam muliswilliam mentioned this issue Jun 3, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Jun 3, 2024

The above requires 1.67.105 or higher for 1.67.x verification 👍

@srirambv
Copy link
Contributor Author

srirambv commented Jun 4, 2024

@muliswilliam something's broken on 1.67.105. Backup screen doesn't work and console logs some errors

38640.mp4

@muliswilliam muliswilliam mentioned this issue Jun 5, 2024
Merged
24 tasks
@srirambv
Copy link
Contributor Author

srirambv commented Jun 5, 2024

Follow up issue #38816

@srirambv
Copy link
Contributor Author

srirambv commented Jun 6, 2024

Verified as part of #38816 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet) Update backup wallet page to onboarding v3 brave/brave-core
4 participants
@kjozwiak @srirambv @brave-builds @muliswilliam