Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer-side changes for improved performance related to adblocking #38029

Closed
ShivanKaul opened this issue May 2, 2024 · 2 comments
Closed
Labels
closed/wontfix dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@ShivanKaul
Copy link
Collaborator

ShivanKaul commented May 2, 2024

For adblocking features such as #33881 and #16935, we need to inject JS into the page. This can often have an adverse effect on the perf of the page, especially if we're inserting MutationObservers into the page. There's some renderer changes we can make to improve perf for these features.

@ShivanKaul ShivanKaul added dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop labels May 2, 2024
@petemill
Copy link
Member

petemill commented May 9, 2024

@iefremov can you elaborate on what the plan would be to make MutationObservers more performant?

@iefremov
Copy link
Contributor

After re-reading slack and the tickets, I think there was a misunderstanding. What I said in DM with shivan/goodov was that Aleksey can actually pick up the original task as an implementor, I didn't have any specific changes in mind (until the JS part is implemented).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Development

No branches or pull requests

3 participants