Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some YT publishers not appearing under BR panel when pasting URL #3800

Closed
kjozwiak opened this issue Mar 20, 2019 · 4 comments
Closed

some YT publishers not appearing under BR panel when pasting URL #3800

kjozwiak opened this issue Mar 20, 2019 · 4 comments
Labels

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Mar 20, 2019

Description

As per https://github.com/brave/browser-android-tabs/issues/1317#issuecomment-472937673, the Rewards panel won't work when directly pasting specific YT publisher URLs into the ombibox.

Steps to Reproduce

  1. launch 0.61.51 Chromium: 73.0.3683.75 & enable rewards
  2. paste https://www.youtube.com/watch?v=UvJl202PlNI into the URL
  3. click on the BAT icon to reveal the Rewards panel

Actual result:

Screen Shot 2019-03-14 at 12 01 17 PM

Expected result:

Screen Shot 2019-03-19 at 11 22 34 PM

Reproduces how often:

100% reproducible when using the above STR.

Brave version (brave://version info)

Brave 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Reproducible on current release:

Yes, reproducible under 0.61.51 Chromium: 73.0.3683.75

  • Does it reproduce on brave-browser dev/beta builds? Yes, reproducible on all channels.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional Information

@NejcZdovc
Copy link
Contributor

+1 from #3789

@btlechowski
Copy link

btlechowski commented Mar 20, 2019

Reproduced on

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

image

@jasonrsadler
Copy link

@kjozwiak This is due to embedding disabled and is fixed in brave/brave-core#1901 (0.64.x)

@NejcZdovc
Copy link
Contributor

closing as dupe of #3335

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Mar 25, 2019
@NejcZdovc NejcZdovc added closed/duplicate Issue has already been reported and removed QA/Test-Plan-Specified QA/Yes bug labels Mar 25, 2019
@kjozwiak kjozwiak removed this from the Dupe / Invalid / Not actionable milestone Mar 26, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants