Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Help tips page in brave://settings #37510

Closed
aguscruiz opened this issue Apr 11, 2024 · 5 comments · Fixed by brave/brave-core#23168
Closed

Remove Help tips page in brave://settings #37510

aguscruiz opened this issue Apr 11, 2024 · 5 comments · Fixed by brave/brave-core#23168
Assignees
@emerick
Labels
feature/settings OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.66.x - Release

Comments

@aguscruiz
Copy link

aguscruiz commented Apr 11, 2024 •
edited by rebron
Loading

Description

We're moving the settings found in Help tips to different sections:

  • Show Wayback Machine prompt on 404 pages moves to the Content section as the last item in the Content subsection.
  • Warn me before closing window with multiple tabs moves to System below the last item in the first subsection.
  • Show warning before quitting with ⌘Q moves to System below the last item in the first subsection.

As a result, the Help tips section is removed from settings.

Steps to Reproduce

  1. Open brave://settings/braveHelpTips

Actual result:

image

Expected result:

  1. Add Wayback machine setting to brave://settings/braveContent
braveContent
  1. Add two warning settings to brave://settings/system
macOS

macOS. For Windows, should be just the Warn me before closing windows with multiple tabs setting.

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@rebron rebron added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/settings QA/Yes release-notes/include priority/P4 Planned work. We expect to get to it "soon". labels Apr 12, 2024
@rebron rebron assigned minkyeongshin and emerick and unassigned rebron and minkyeongshin Apr 12, 2024
@rebron rebron removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Apr 18, 2024
@emerick emerick mentioned this issue Apr 19, 2024
Merged
24 tasks
@emerick emerick added this to the 1.67.x - Nightly milestone Apr 19, 2024
@stephendonner
Copy link

stephendonner commented Apr 22, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.67.31 Chromium: 124.0.6367.60 (Official Build) nightly (64-bit)
-- | --
Revision | 5d142aa04ae5b4f6447932c461da4cda17db69d9
OS | Windows 10 Version 22H2 (Build 19045.4291)

Shared Steps:

  1. installed 1.67.31
  2. launched Brave
  3. opened the respective brave://settings page/sub-page, as referenced below
  4. confirmed each noted change

Help Tips removal:

image

Confirmed Help Tips -- which contained the moved preferences from below -- was removed as a top-level section

Content:

image

Confirmed Show Wayback Machine prompt on 404 pages was moved to brave://settings/braveContent

System:

image

Confirmed Warn me before closing windows with multiple tabs was moved to brave://settings/system

@brave-builds brave-builds mentioned this issue Apr 25, 2024
Merged
7 tasks
@LaurenWags
Copy link
Member

Removing QA Pass-Win64 as this has been uplifted to 1.66.x and needs to be re-verified.

Requires 1.66.92 or higher for testing.

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA Pass-Win64 labels Apr 29, 2024
@stephendonner
Copy link

stephendonner commented Apr 29, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.66.94 Chromium: 124.0.6367.91 (Official Build) beta (x86_64)
-- | --
Revision | 1574096f9d2bcb69c3654cb4437217121ee9600b
OS | macOS Version 11.7.10 (Build 20G1427)

Shared Steps:

  1. installed 1.66.94
  2. launched Brave
  3. opened the respective brave://settings page/sub-page, as referenced below
  4. confirmed each noted change

Help Tips removal:

Confirmed Help Tips -- which contained the moved preferences from below -- was removed as a top-level section

Screen Shot 2024-04-29 at 10 41 13 AM

Content:

Confirmed Show Wayback Machine prompt on 404 pages was moved to brave://settings/braveContent

Screen Shot 2024-04-29 at 10 40 09 AM

System:

Confirmed Warn me before closing windows with multiple tabs was moved to brave://settings/system, as well as Show warning before quitting with ⌘Q

Screen Shot 2024-04-29 at 10 39 19 AM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 29, 2024
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 29, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.66.94 Chromium: 124.0.6367.91 (Official Build) beta (64-bit)
-- | --
Revision | 1574096f9d2bcb69c3654cb4437217121ee9600b
OS | Windows 11 Version 23H2 (Build 22631.3527)

Shared Steps:

  1. installed 1.66.94
  2. launched Brave
  3. opened the respective brave://settings page/sub-page, as referenced below
  4. confirmed each noted change

Help Tips removal:

Confirmed Help Tips was removed from settings sidebar -- which contained the moved preferences from below

1.65.x 1.66.x
image image

Content:

Confirmed Show Wayback Machine prompt on 404 pages was moved to brave://settings/braveContent

1.65.x 1.66.x (light theme) 1.66.x (dark theme)
image image image

System:

Confirmed Warn me before closing windows with multiple tabs was moved to brave://settings/system in the first subsection

1.65.x 1.66.x (light theme) 1.66.x (dark theme)
image image image

@MadhaviSeelam
Copy link

Verification PASSED using

Brave	1.66.94 Chromium: 124.0.6367.91 (Official Build) beta (64-bit) 
Revision	1574096f9d2bcb69c3654cb4437217121ee9600b
OS	Linux

Shared Steps:

  1. installed 1.66.94
  2. launched Brave
  3. opened the respective brave://settings page/sub-page, as referenced below
  4. confirmed each noted change

Help Tips removal:

Confirmed Help Tips was removed from settings sidebar -- which contained the moved preferences from below

1.65.x 1.66.x
image image

Content:

Confirmed Show Wayback Machine prompt on 404 pages was moved to brave://settings/braveContent

1.65.x 1.66.x (light theme) 1.66.x (dark theme)
image image image

System:

Confirmed Warn me before closing windows with multiple tabs was moved to brave://settings/system in the first subsection

1.65.x 1.66.x (light theme) 1.66.x (dark theme)
image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Linux QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 29, 2024
@rebron rebron changed the title Browser settings - Move "help tips" contents Remove Help tips page in brave://settings May 2, 2024
@LaurenWags LaurenWags mentioned this issue May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/settings OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

Move help tips settings and remove section brave/brave-core
8 participants
@stephendonner @emerick @rebron @aguscruiz @LaurenWags @brave-builds @minkyeongshin @MadhaviSeelam