Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hide Token Button in Portfolio List View #37193

Closed
Douglashdaniel opened this issue Mar 28, 2024 · 1 comment · Fixed by brave/brave-core#22847
Closed

Add Hide Token Button in Portfolio List View #37193

Douglashdaniel opened this issue Mar 28, 2024 · 1 comment · Fixed by brave/brave-core#22847
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.66.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to add a Hide token button in the Portfolio list view.

Expected result:

Screen.Recording.8.mov
@Douglashdaniel Douglashdaniel added enhancement QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 28, 2024
@Douglashdaniel Douglashdaniel self-assigned this Mar 28, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Mar 28, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Mar 28, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Mar 28, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 29, 2024
@brave-builds brave-builds added this to the 1.66.x - Nightly milestone Mar 29, 2024
@srirambv
Copy link
Contributor

srirambv commented May 2, 2024

Verification passed on

Brave 1.66.97 Chromium: 124.0.6367.118 (Official Build) beta (64-bit)
Revision 94909f2aaefd7a8137c8b4fa27235378e79231e3
OS Windows 11 Version 23H2 (Build 22631.3527)
  • Verified steps from brave/brave-core#22847
  • Verified able to hide token from more menu on portfolio
  • Verified balance updates when the token is hidden
  • Verified Unhiding the token from edit visible list token gets listed in the portfolio and balance updates automatically
  • Verified hide/unhide token works as expected from account details view
37193.mp4

@LaurenWags LaurenWags mentioned this issue May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Hide Token Button in Portfolio brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds