Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL tooltips on new tab page show chrome:// links not brave:// #3701

Closed
NickAnEngineer opened this issue Mar 13, 2019 · 2 comments
Closed

URL tooltips on new tab page show chrome:// links not brave:// #3701

NickAnEngineer opened this issue Mar 13, 2019 · 2 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@NickAnEngineer
Copy link

Description

URL tooltips on new tab screen show chrome:// links not brave:// links for settings bookmarks and history. When they are actually clicked they resolve to brave:// in the URL bar

Steps to Reproduce

  1. Open a new tab
  2. Mouse over settings, history or bookmarks
  3. Observe in bottom left

Actual result:

image

Expected result:

The brave URLs should be shown

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 0.60.48 Chromium: 72.0.3626.121 (Official Build) (64-bit)
Revision | da3787ba355f18db7db52abf75c42afb408d656f-refs/branch-heads/3626@{#883}
OS | Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional Information

@srirambv
Copy link
Contributor

Should be fixed as part of #326 and #1616 (#1774)

@srirambv srirambv added the closed/duplicate Issue has already been reported label Mar 13, 2019
@srirambv srirambv added this to the Dupe / Invalid / Not actionable milestone Mar 13, 2019
@simonhong
Copy link
Member

This is duplicated with #2566 and fixed today :)

@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

4 participants