Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error being returned when sending feedback for Leo responses (rating) #36652

Closed
Uni-verse opened this issue Mar 8, 2024 · 3 comments
Closed

Comments

@Uni-verse
Copy link
Contributor

Description:

When sending feedback for Leo responses, it returns general error banner

URL: https://feedback.brave.com/1/ai/feedback/rating

Request:
{
	"channel": "unknown",
	"chat": [{
		"content": "Test",
		"id": 0,
		"type": "human"
	}, {
		"content": "Hello! I'm here to help. Could you please provide more details about what you'd like to test or learn about? This will enable me to give you a more accurate and useful response. Looking forward to assisting you!",
		"id": 1,
		"type": "assistant"
	}],
	"is_premium": false,
	"locale": "en_US",
	"model": "mixtral-8x7b-instruct",
	"platform": "ios",
	"rating": 1,
	"ymd": "2024-03-08"
}
Response:
{
	"Renderer": null,
	"statusCode": 400,
	"error": "Bad Request",
	"message": "invalid platform"
}

Steps to Reproduce

  1. Enable Leo
  2. Submit query
  3. Long-press on response, select Like or Dislike

Actual result:

IMG_5798

Expected result:

Should not show error

Reproduces how often: [Easily reproduced, Intermittent Issue]

Always

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? No (new feature)
  • Can you reproduce this issue with the current build from AppStore? No (new feature)

Device details:

iPhone 12

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

@Uni-verse Uni-verse added bug QA/Yes release-notes/exclude OS/iOS Fixes related to iOS browser functionality browser-ai labels Mar 8, 2024
@Uni-verse Uni-verse changed the title Error being returned when sending feedback for Leo responses (Like/Dislike) Error being returned when sending feedback for Leo responses (rating) Mar 8, 2024
@iccub iccub assigned Brandon-T and unassigned Brandon-T Mar 13, 2024
@porteron
Copy link
Member

The issue was the serverside endpoint only accepted Brave Core platforms. This has been resolved as of this morning: https://github.com/brave-intl/go-vault/pull/222.

@kjozwiak
Copy link
Member

Thanks @porteron 👍 Moving into 1.63.x so this can get re-checked by QA. CCing @hffvld @Uni-verse.

@Uni-verse
Copy link
Contributor Author

Verified on iPhone 12 running iOS 17.3.1 using version 1.62 (173)

  • Ensured Like/Disliking post will successfully show confirmation banner.
  • Ensured tapping on X in the Liked banner will dismiss the confirmation banner.
  • Ensured banners will automatically dismiss after 4-5 seconds.
Liked Dislike
IMG_5838 IMG_5842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants