Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full page google doc summarization support #36649

Closed
Tracked by #35733
darkdh opened this issue Mar 8, 2024 · 2 comments · Fixed by brave/brave-core#22612
Closed
Tracked by #35733

Full page google doc summarization support #36649

darkdh opened this issue Mar 8, 2024 · 2 comments · Fixed by brave/brave-core#22612
Assignees
@darkdh
Labels
browser-ai OS/Desktop OS/macOS OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.67.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Mar 8, 2024 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#22612

Description

Current screenshot method can only extract text from pages in the viewport, it would be 1 or 2 pages depends on how big the screen is or zoom ratio.
We will use print preview extraction method to get full pages of context and then extract text from it.
@darkdh darkdh self-assigned this Mar 8, 2024
@darkdh darkdh added this to Browser AI Mar 8, 2024
@darkdh darkdh moved this to In Progress in Browser AI Mar 8, 2024
@mattmcalister mattmcalister added QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 13, 2024
@darkdh darkdh mentioned this issue Mar 14, 2024
Merged
24 tasks
@darkdh darkdh moved this from In Progress to In Review in Browser AI Mar 14, 2024
@mattmcalister mattmcalister mentioned this issue Mar 21, 2024
Closed
18 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Browser AI Apr 12, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 12, 2024
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 30, 2024
@stephendonner
Copy link

stephendonner commented Apr 30, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.66.103 Chromium: 124.0.6367.159 (Official Build) beta (x86_64)
-- | --
Revision | 74d46bb25d9ea5e6432e19f0cf38480cc372b0cf
OS | macOS Version 11.7.10 (Build 20G1427)

Shared Steps:

  1. installed 1.67.52
  2. launched Brave
  3. clicked on Leo in the sidebar
  4. entered test
  5. clicked on I understand

Case 1: Regression test on previous Google Doc support - PASSED

  • downloaded a newspaper template from https://thegoodocs.com/download
  • copied it
  • clicked on Summarize this page

Confirmed page summarization was accurate

Screen Shot 2024-05-08 at 12 01 11 PM

Case 2: Test full-page Google Doc support - PASSED

  • opened my Senior thesis (14 pages)
  • clicked on Summarize this page

Confirmed accurate summary

Screen Shot 2024-04-30 at 5 10 47 PM

Case 3: Test Google Docs page limit (20) - PASSED

  • open a google doc with 19 pages of blank pages and 2 pages with completely different scoped of contents
  • summarize the page

Summary should be only relevant to 20th page but not 21st page

Screen Shot 2024-05-08 at 11 58 24 AM

Case 4: Compatibility with print dialog - PASSED

  • open a Google Doc and print it
  • when print dialog is open, open Leo panel and summarize the page
  • summary should show up
  • close print dialog and trigger print again

Confirmed correct Leo summarization and print-dialog functionality

example example example example
Screen Shot 2024-04-30 at 5 38 34 PM Screen Shot 2024-04-30 at 5 39 28 PM Screen Shot 2024-04-30 at 5 40 48 PM Screen Shot 2024-04-30 at 5 41 08 PM

This was referenced May 1, 2024
Closed
Closed
@stephendonner stephendonner added QA Pass-macOS QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 8, 2024
@stephendonner
Copy link

stephendonner commented May 8, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.66.103 Chromium: 124.0.6367.159 (Official Build) beta (64-bit)
-- | --
Revision | 74d46bb25d9ea5e6432e19f0cf38480cc372b0cf
OS | Windows 10 Version 22H2 (Build 19045.4355)

Shared Steps:

  1. installed 1.66.103
  2. launched Brave
  3. clicked on Leo in the sidebar
  4. entered test
  5. clicked on I understand

Case 1: Regression test on previous Google Doc support - PASSED

  • downloaded a newspaper template from https://thegoodocs.com/download
  • copied it
  • clicked on Summarize this page

Confirmed page summarization was accurate

image

Case 2: Test full-page Google Doc support - PASSED

  • opened my Senior thesis (14 pages)
  • clicked on Summarize this page

Confirmed accurate summary

image

Case 3: Test Google Docs page limit (20) - PASSED

  • open a google doc with 19 pages of blank pages and 2 pages with completely different scoped of contents
  • summarize the page

Summary should be only relevant to 20th page but not 21st page

image

Case 4: Compatibility with print dialog - PASSED

  • open a Google Doc and print it
  • when print dialog is open, open Leo panel and summarize the page
  • summary should show up
  • close print dialog and trigger print again

Confirmed correct Leo summarization and print-dialog functionality

example example example example
image image image image

@stephendonner stephendonner added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 8, 2024
@LaurenWags LaurenWags mentioned this issue Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
browser-ai OS/Desktop OS/macOS OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Browser AI
Status: Done
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

Introduce print preview extraction brave/brave-core
4 participants
@mattmcalister @stephendonner @darkdh @brave-builds