Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Rewards Statement view #36522

Closed
Miyayes opened this issue Mar 3, 2024 · 2 comments · Fixed by brave/brave-core#22755
Closed

Remove Rewards Statement view #36522

Miyayes opened this issue Mar 3, 2024 · 2 comments · Fixed by brave/brave-core#22755
Assignees
@zenparsing @mkarolin
Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.66.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 3, 2024 •
edited
Loading

Description

Remove Rewards Statement.

Note: A-C history can still be seen in rewards-internals. We can re-implement this specifically for A-C in future.
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 6, 2024
@zenparsing zenparsing mentioned this issue Mar 25, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.66.x - Nightly milestone Mar 26, 2024
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 5, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Apr 5, 2024 •
edited
Loading

Verified with

Brave | 1.66.62 Chromium: 123.0.6312.105 (Official Build) nightly (x86_64)
-- | --
Revision | e8a70be9c00281c647c9b196de8eb0c4532a9be4
OS | macOS Version 13.6.6 (Build 22G630)
Clean Profile - PASSED
  1. Clean profile, close and relaunch to pull griffin.
  2. Join Rewards, do not connect a custodian.
  3. View some ads
  4. Confirm no "Monthly Statement" on brave://rewards page
Wide Narrow
a b
  1. Connect to a custodian
  2. Confirm no "Monthly Statement" on brave://rewards page
Wide Narrow
c d
  1. Confirm able to populate the Auto Contribution list
Screenshot 2024-04-09 at 12 44 56 PM
  1. Perform an Auto Contribution
Example Example
Screenshot 2024-05-06 at 1 16 21 PM Screenshot 2024-05-06 at 1 16 28 PM
  1. Confirm AC information is listed on brave://rewards-internals
Screenshot 2024-05-06 at 1 15 39 PM
  1. Do a tip (one time or monthly)
Example Example
Screenshot 2024-05-06 at 1 18 38 PM Screenshot 2024-05-06 at 1 18 44 PM
  1. Confirm tip information is displayed on brave://rewards-internals
Screenshot 2024-05-06 at 1 18 56 PM
  1. Reset Rewards
Screenshot 2024-05-06 at 1 19 30 PM Screenshot 2024-05-06 at 1 19 37 PM
  1. Connect to other custodians and confirm no "Monthly Statement" on brave://rewards page in wide or narrow views
Gemini ZebPay BitFlyer
Screenshot 2024-04-17 at 3 55 25 PM Screenshot 2024-04-29 at 9 32 00 AM Screenshot 2024-04-17 at 4 05 16 PM
Screenshot 2024-04-17 at 3 55 44 PM Screenshot 2024-04-29 at 9 32 12 AM Screenshot 2024-04-17 at 4 05 24 PM

Encountered #37941 when testing the below scenario.

Upgrade Profile - PASSED
  1. Install 1.65.x, close and relaunch to pull griffin.
  2. Join Rewards, connect a custodian.
  3. View some ads
  4. Populate the Auto Contribution list
  5. Do a tip (one time or monthly)
Example Example Example
Screenshot 2024-04-29 at 1 14 34 PM Screenshot 2024-04-29 at 1 14 45 PM Screenshot 2024-04-29 at 1 14 49 PM
  1. Upgrade to 1.66.x (rename profile)
  2. Visit brave://rewards
  3. Confirm previously populated data remains
Example Example Example
Screenshot 2024-04-29 at 1 18 05 PM Screenshot 2024-04-29 at 1 18 13 PM Screenshot 2024-04-29 at 1 18 20 PM
  1. Confirm no "Monthly Statement" on brave://rewards page in wide or narrow views
Example Example
Screenshot 2024-04-29 at 1 18 30 PM Screenshot 2024-04-29 at 1 18 35 PM

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 29, 2024
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 30, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 30, 2024 •
edited
Loading

Verification PASSED on

Brave | 1.66.94 Chromium: 124.0.6367.91 (Official Build) beta (64-bit)
-- | --
Revision | 1574096f9d2bcb69c3654cb4437217121ee9600b
OS | Windows 10 Version 22H2 (Build 19045.4291)
Clean Profile - PASSED
  1. Clean profile, close and relaunch to pull griffin.
  2. Join Rewards, do not connect a custodian.
  3. View some ads
  4. Confirm no "Monthly Statement" on brave://rewards page
Wide Narrow
image image
  1. Connect to a custodian
  2. Confirm no "Monthly Statement" on brave://rewards page
Wide Narrow
image image
  1. Confirm able to populate the Auto Contribution list

image

  1. Perform an Auto Contribution
Example Example
image image
  1. Confirm AC information is listed on brave://rewards-internals

image

  1. Do a tip (one time or monthly)
Example Example
image image
  1. Confirm tip information is displayed on brave://rewards-internals

image

  1. Reset Rewards
image image
  1. Connect to other custodians and confirm no "Monthly Statement" on brave://rewards page in wide or narrow views
Gemini ZebPay BitFlyer
image image
image image

Encountered #37941 when testing the below scenario.

Upgrade Profile - PASSED
  1. Install 1.65.x, close and relaunch to pull griffin.
  2. Join Rewards, connect a custodian.
  3. View some ads
  4. Populate the Auto Contribution list
  5. Do a tip (one time or monthly)
Example Example Example
image image image
  1. Upgrade to 1.66.x (rename profile)
  2. Visit brave://rewards
  3. Confirm previously populated data remains
Example Example Example
image image image
  1. Confirm no "Monthly Statement" on brave://rewards page in wide or narrow views
Example Example
image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 2, 2024
@LaurenWags LaurenWags mentioned this issue May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

@mkarolin mkarolin

Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Brave Rewards
Status: Done
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

Remove Rewards monthly statement brave/brave-core
6 participants
@zenparsing @Miyayes @LaurenWags @GeetaSarvadnya @mkarolin @brave-builds