Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connected Dapps text has extra padding #36429

Closed
srirambv opened this issue Feb 28, 2024 · 2 comments · Fixed by brave/brave-core#22377
Closed

Connected Dapps text has extra padding #36429

srirambv opened this issue Feb 28, 2024 · 2 comments · Fixed by brave/brave-core#22377
Assignees
@StephenHeaps
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.63.x - Release #4

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 28, 2024 •
edited
Loading

Description:

Connected Dapps text has extra padding

Steps to Reproduce

  1. Install 1.63 build
  2. Open any account which doesn't have a connected site
  3. Connected Dapps text is not left aligned

Actual result:

Expected result:

No padding should be left aligned to keep consistency

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? NA
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

All

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?NA
  • Is the issue reproducible on the latest version of Mobile Safari? NA

Additional Information

cc: @nuo-xu @StephenHeaps
@srirambv srirambv added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality labels Feb 28, 2024
@srirambv srirambv added this to Web3 Feb 28, 2024
@srirambv srirambv changed the title Connected site text has extra padding Connected Dapps text has extra padding Feb 28, 2024
@srirambv srirambv mentioned this issue Feb 28, 2024
Closed
@StephenHeaps StephenHeaps self-assigned this Feb 28, 2024
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Feb 28, 2024
@StephenHeaps StephenHeaps mentioned this issue Feb 28, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Feb 28, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 28, 2024
This was referenced Feb 29, 2024
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2024

The above requires 1.63.169 or higher for 1.63.x verification 👍

@kjozwiak kjozwiak mentioned this issue Mar 6, 2024
Closed
26 tasks
@srirambv
Copy link
Contributor Author

srirambv commented Mar 6, 2024

Verification passed on iPhone 13 with iOS 17.4 running 1.63 (169)

36429.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenHeaps StephenHeaps

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.63.x - Release #4
Development

Successfully merging a pull request may close this issue.

fix(wallet): Left-align DApp connections empty state label on iOS brave/brave-core
4 participants
@kjozwiak @StephenHeaps @srirambv @brave-builds