-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings re-organization for Privacy/Security/Shields sections #36363
Comments
Seems to me like Tor is a privacy feature (hiding IP address), not a security feature. |
I could go either way on Tor, one consideration was that the Privacy section was already full. We could alternatively rename the Security section "Security & Tor Mode" |
@rebron it would be good to have a link to https://brave.com/privacy-updates/7-ephemeral-storage/ somewhere where we talk about 3p cookies in settings, similar to how Firefox has a link to Total Cookie Protection where the user can choose cookie policy. This is a niche concern but it is true that we are not technically outright blocking 3p cookies in all cases, we're partitioning them by top-level site for frames and clear them when the tab closes (which is more protective than FF which partitions but never deletes.) |
Option 1: Tor in the Shields and Privacy section Option 2: Tor in the Security section Thanks @minkyeongshin for the design mocks. |
@ShivanKaul @diracdeltas Options 1 and 2 above based on the original description. |
@fmarier wdyt about putting Tor into Security and renaming it "Security & Tor Mode", based on the screenshots above? |
Another thing that's going to be a little weird after the switch is:
They're both security features which improve privacy, but they're in different top-level sections. |
Looking at the new security settings, these are mostly things that don't really deserve top-level real estate:
and then we have the Safety Check section which is pretty useless in Brave to be honest and should probably just be removed. Maybe we don't need a top-level security section? |
Option 3 feels like a good first step to me. @rebron what do you think about hiding the Safety check section entirely? I don't think it's providing a lot of value in Brave. |
Closing as a dupe of #36859. Fix will be reflected/released in 1.66.x. |
Proposed changes in brave://settings:
Privacy and Shields
. Icon can be the existing Shields icon.Auto-redirect AMP pages
,Auto-redirect tracking URLs
andPrevent sites from fingerprinting me based on my language preferences
into Privacy.Privacy and Shields
calledData Collection
and move P3A, daily usage ping and diagnostic reports under it. This is independently useful and can be done in a separate work item as well.Security
to be its own top-level settings menu. Icon can be existing icon forPrivacy and security
. brave://settings/security will become a top level menu item that contains:The text was updated successfully, but these errors were encountered: