Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time out sync reset if device is offline #3628

Closed
srirambv opened this issue Mar 7, 2019 · 1 comment · Fixed by brave/brave-core#4089
Closed

Time out sync reset if device is offline #3628

srirambv opened this issue Mar 7, 2019 · 1 comment · Fixed by brave/brave-core#4089

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 7, 2019

Description

Time out sync reset if device is offline

Steps to Reproduce

  1. Create sync chain on desktop with another device
  2. Disconnect device from network
  3. Try to delete the device from sync chain, keeps showing the remove device modal, laptop engines start revving up at 3000 RPM and is ready to take off

Actual result:

Device never gets removed from sync chain if device is offline

Expected result:

Should time out and cancel request to remove after a short interval

Reproduces how often:

Easy

Brave version (brave://version info)

All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Bringing device back online, modal doesn't close (device is not removed)
cc: @darkdh @AlexeyBarabash

@srirambv
Copy link
Contributor Author

srirambv commented Feb 7, 2020

Verification passed on

Brave 1.3.112 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.165)
  • Verified test plan from Fix 3628 offline reset brave-core#4089
  • Verified device can be removed from sync chain when offline
  • Verified no bookmarks are sent across even though the device is listed but removed from sync chain

Verification passed on

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS
  • Verified test plan from Fix 3628 offline reset brave-core#4089
  • Verified device can be removed from sync chain when offline
  • Verified no bookmarks are sent across even though the device is listed but removed from sync chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants