Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash from adblock rules with $from option #36275

Closed
antonok-edm opened this issue Feb 21, 2024 · 0 comments · Fixed by brave/brave-core#22226
Closed

Crash from adblock rules with $from option #36275

antonok-edm opened this issue Feb 21, 2024 · 0 comments · Fixed by brave/brave-core#22226
Assignees
@antonok-edm
Labels
crash dependencies Pull requests that update a dependency file dev-concern OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Milestone
1.63.x - Release

Comments

@antonok-edm
Copy link
Collaborator

brave/adblock-rust#336 (v0.8.8) needs to be ported to brave-core to prevent $from rules from crashing the browser.
@antonok-edm antonok-edm added crash QA/No dev-concern release-notes/exclude dependencies Pull requests that update a dependency file OS/iOS Fixes related to iOS browser functionality labels Feb 21, 2024
@antonok-edm antonok-edm self-assigned this Feb 21, 2024
@antonok-edm antonok-edm mentioned this issue Feb 21, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 21, 2024
This was referenced Feb 21, 2024
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Mar 4, 2024
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
crash dependencies Pull requests that update a dependency file dev-concern OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
1.63.x - Release
Development

Successfully merging a pull request may close this issue.

update adblock-rust to v0.8.8 brave/brave-core
2 participants
@antonok-edm @brave-builds