Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapping on Suggestion questions once rate limit reached doesn't do anything/displays spinner #36144

Closed
Tracked by #35733
kjozwiak opened this issue Feb 16, 2024 · 1 comment
Assignees
Labels
closed/duplicate Issue has already been reported

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Feb 16, 2024

Description

Once you've reached the rate limit for either either Mixtral or Calude Instant, clicking on Suggestion questions... doesn't do anything. You'll see a loading spinner but nothing will happen. If you tap on Summarise, you'll instantly get the rate limit upsell UX/UI within Leo.

We should either be displaying the upsell UI when a user clicks on Suggest questions or display some error message indicating that the rate limit has been reached. In the current state, it looks like we're trying to retrieve a response but it's taking too long.

Steps to reproduce

Note: this assumes that you've already gone through onboarding and have reached the rate limit on one of the premium LLM's

  1. once you've reached the rate limit on either Mixtral or Calude Instant, load any website/article
  2. tap on Suggestion questions... (notice that the spinner will keep animating but nothing happens)
  3. wait ~1min or so and notice that the spinner animation is still going but nothing is happening
  4. tap on Summarise and you'll instantly get the rate limit upsell UX/UI

Actual result

screen-20240215-225719.mp4

Expected result

As mentioned above, we should either display the rate limit upsell or display an error indicating that the limit has been reached.

Issue reproduces how often

100% reproducible when using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A (but present within the 1.63.x RC)
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6
  • Android version: Android 14

Brave version

Brave | 1.63.155 Chromium: 122.0.6261.29 (Official Build) (64-bit)
--- | ---
Revision | b2be2c6f5b7340629f672ce706f5bfd62b113f82
OS | Android 14; Build/AP11.231215.009; 34; REL

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@kjozwiak kjozwiak added bug QA/Yes OS/Android Fixes related to Android browser functionality browser-ai labels Feb 16, 2024
@mattmcalister mattmcalister moved this to Alignment #3 - Mobile MVP in Browser AI Feb 16, 2024
@mattmcalister mattmcalister added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 16, 2024
@kjozwiak
Copy link
Member Author

Closing the above as a duplicate as we have #35929 already opened for the above issue.

@github-project-automation github-project-automation bot moved this from Alignment #3 - Mobile MVP to Done in Browser AI Feb 16, 2024
@kjozwiak kjozwiak added closed/duplicate Issue has already been reported and removed bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes OS/Android Fixes related to Android browser functionality browser-ai labels Feb 16, 2024
@kjozwiak kjozwiak removed this from Browser AI Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

3 participants