Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sync] Full History Sync not working correctly anymore (Brave or new History datatype issue?) #34116

Closed
ghost opened this issue Nov 5, 2023 · 1 comment
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@ghost
Copy link

ghost commented Nov 5, 2023

Description

I reset my Phones storage and the old History is not synching anymore to my Android phone. I tested from PC to Android first, but also from PC to PC by having a new user data with --user-data-dir= and nothing.

I used to work fine with Brave's old implementation: brave/brave-core#16705, but seems like the official History datatype implementation brave/brave-core#20329 is not working correctly.

Many things are happening here, but now it fails to work properly like in the past, for example:

  • When the devices are joined, it will not sync the old items, only new History items

  • My main computer is the one with all the many history items, and when I visited a site I previously had in my History, the new items synched okay to other devices and deleting the items, deleted the items.
    The thing is that after a while, some old history items got synched, only one day from ONLY the site I just visited and deleted, but nothing else. just like 3 items, 2 from yesterday and 1 from October 25th. I tested with Twitch for example, and if I visited the Smite game directory many times in the past, only the latest item from October 24th was synched. and not the older ones.
    So yes, it seems sometimes only one item is getting synched and only the latest entry, but nothing else, and it is only triggered when the 'new' History item is removed, and then it syncs the old one, far from synching, especially the old implementation that seemed to do the job pretty good.

  • Also I got a 'hiccup' for new History items, when I made a brave search 'test' in Android, and then I removed it from my phone, and it still appeared in my normal user data, although other history items removed seemed to work fine.
    Sync-Internals increased the History Delete Directives counter, but seems like it still didn't delete it properly across devices.

If this is meant to work this way, it was working better when History was synched with the 'TypedURLs' data type. If it is not something that should happening, I am reporting this so it gets fixed.
Also, since the flags were removed to go back to the 'old ways', well, no way to test it, it might work fine in the older implementation, and since the new History datatype is the 'future' to keep it with Chromium implementation, then I won't test it on anything but the latest Nightly.

@AlexeyBarabash

Steps to Reproduce

  1. Have a device with some history
  2. Create a Sync Chain
  3. Select History
  4. Nothing will get synched
  5. If you have old history data from days ago, and you visit the site, sometimes some elements get synched from that site but not 'all'

Actual result:

History not synching old items

Expected result:

All history in sync between devices

Reproduces how often:

Always

Desktop Brave version:

1.62.25 Chromium: 119.0.6045.105 (Official Build) nightly (64-bit) on PC and Android.

Android Device details:

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 13
@ghost ghost added OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 5, 2023
@ghost ghost changed the title [Sync] History datatype Sync not working correctly, old history items no synching correctly, and some new items not getting properly deleted [Sync] Full History Sync not working correctly anymore (Brave or new History datatype issue?) Nov 5, 2023
@bsclifton
Copy link
Member

Closing as duplicate of #35042

@bsclifton bsclifton added the closed/duplicate Issue has already been reported label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Development

No branches or pull requests

1 participant