Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More clenup sync v1 migration obsolete code #33113

Closed
AlexeyBarabash opened this issue Sep 19, 2023 · 0 comments · Fixed by brave/brave-core#20906
Closed

More clenup sync v1 migration obsolete code #33113

AlexeyBarabash opened this issue Sep 19, 2023 · 0 comments · Fixed by brave/brave-core#20906
Assignees
@AlexeyBarabash
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Milestone
1.62.x - Release

Comments

@AlexeyBarabash
Copy link
Contributor

These functions are no longer required:
BraveClearSyncV1MetaInfo
BraveMigrateOtherNodeFolder
migration at BraveSyncServiceImpl::Initialize
brave_sync::Prefs::IsSyncV1Migrated
brave_sync::Prefs::SetSyncV1Migrated
brave_sync::Prefs::IsSyncV1MetaInfoCleared
brave_sync::Prefs::SetSyncV1MetaInfoCleared
brave_sync::Prefs::IsSyncMigrateNoticeDismissed
brave_sync::Prefs::SetDismissSyncMigrateNotice
and classes
class SyncV2MigrateInfoBarDelegate
class BraveSyncInformers (BraveSyncInformers.java)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

Cleanup sync v1 migration brave/brave-core
2 participants
@AlexeyBarabash @brave-builds