Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mojo method to return swap protocol fees #32464

Closed
onyb opened this issue Aug 23, 2023 · 2 comments · Fixed by brave/brave-core#19834
Closed

Add mojo method to return swap protocol fees #32464

onyb opened this issue Aug 23, 2023 · 2 comments · Fixed by brave/brave-core#19834
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.59.x - Release

Comments

@onyb
Copy link
Member

onyb commented Aug 23, 2023

Implement a backend method that computes the appropriate protocol fee to be displayed to users.

Note: The 0x protocol fee may be waived for some tokens, which can only be inferred from the quote response, i.e., cannot be known in advance.
@onyb onyb added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/swap labels Aug 23, 2023
@onyb onyb self-assigned this Aug 23, 2023
@onyb onyb added this to Web3 Aug 23, 2023
@onyb onyb mentioned this issue Aug 23, 2023
Merged
25 tasks
@onyb onyb moved this to In Review in Web3 Aug 23, 2023
@StephenHeaps StephenHeaps mentioned this issue Aug 23, 2023
Closed
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Aug 24, 2023
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 24, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.59.93 x64 build

32464.mp4

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.59.100 Chromium: 117.0.5938.92 (Official Build) beta (64-bit)
Revision 3243fffc43431ab8677e8139859670b4cd2df843
OS Windows 11 Version 22H2 (Build 22621.2283)
32464.mp4

@LaurenWags LaurenWags mentioned this issue Oct 10, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): introduce swap protocol fees brave/brave-core
3 participants
@onyb @srirambv @brave-builds