Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut for New window shows Command + NumDecimal, rather than Command + N #31552

Closed
stephendonner opened this issue Jul 10, 2023 · 2 comments · Fixed by brave/brave-core#19219

Comments

@stephendonner
Copy link

Description

Shortcut for New window shows Command + NumDecimal, rather than Command + N

Steps to Reproduce

  1. install 1.58.7
  2. launch Brave
  3. open brave://settings/system/shortcuts
  4. type new window
  5. examine the keybinding/shortcut

Actual result:

Shows Command + NumDecimal

Screen Shot 2023-07-10 at 4 17 01 PM

Expected result:

Should show Command + N

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.58.7 Chromium: 115.0.5790.75 (Official Build) nightly (x86_64)
Revision db3af86
OS macOS Version 11.7.8 (Build 20G1351)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @fallaciousreasoning @rebron @brave/qa-team

@LaurenWags
Copy link
Member

@brave/qa-team this requires 1.56.5 or higher for 1.56.x verification

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.56.5 Chromium: 115.0.5790.75 (Official Build) (x86_64)
Revision 3433e4d513e8454ba0243deea3d53693661dc0c3-refs/branch-heads/5790@{#1430}
OS macOS Version 11.7.8 (Build 20G1351)

Followed my original steps to reproduce from #31552 (comment).

Confirmed the shortcut binding for New window is Command + N, and works

brave://settings/system/shortcuts New window
Screen Shot 2023-07-12 at 3 00 58 PM Screen Shot 2023-07-12 at 3 04 53 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment