Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #17434 - Long domain names overflow in Rewards Show -All screen #30858

Closed
GeetaSarvadnya opened this issue Jun 6, 2023 · 1 comment · Fixed by brave/brave-core#18870

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #17434
Follow up of #17434 - Long domain names overflow Rewards Show -All screen

Steps to Reproduce

  1. Please see STR from Long domain names overflow Rewards screen #17434 (comment)

Actual result:

Long domain names overflow in Rewards Show -All screen
long domain names in show all popup modal

Expected result:

Long domain names should not overflow in Rewards Show -All screen

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.53.82 Chromium: 114.0.5735.90 (Official Build) beta (64-bit)
Revision 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}
OS Windows 10 Version 22H2 (Build 19045.2965)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Not sure
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Not sure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @mkarolin @Miyayes

@GeetaSarvadnya GeetaSarvadnya changed the title Follow up of #17434 - Long domain names overflow Rewards Show -All screen Follow up of #17434 - Long domain names overflow in Rewards Show -All screen Jun 6, 2023
@Miyayes Miyayes added the priority/P4 Planned work. We expect to get to it "soon". label Jun 6, 2023
@mkarolin mkarolin added this to the 1.54.x - Nightly milestone Jun 13, 2023
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 10, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Jul 10, 2023

Verified with

Brave | 1.57.10 Chromium: 115.0.5790.75 (Official Build) beta (x86_64)
-- | --
Revision | 6fbe50fcb5cd24cd6bd0fe48aee3a108eb21441e
OS | macOS Version 13.4.1 (a) (Build 22F770820b)

Verified long domain names do not overflow on the Auto Contribute "Show All" screens.

Example Example
1 2

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants