Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding doesn't auto navigate to the next step when going back to brave://welcome screen #3069

Closed
srirambv opened this issue Jan 24, 2019 · 4 comments
Assignees
Labels
about-pages/welcome closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude suggestion

Comments

@srirambv
Copy link
Contributor

Description

Onboarding doesn't auto navigate to the next step when going back to brave://welcome screen

Steps to Reproduce

  1. Clean profile
  2. Click Lets go on the first screen
  3. Click on Import, opens importer screen in a new tab
  4. Switch back to brave://welcome, automatically navigates to the next step
  5. Click on Settings, opens settings page in a new tab
  6. Switch back to brave://welcome, doesn't navigate to the next step, user has to manually navigate
  7. Repeat for all the subsequent steps, same doesn't auto navigate to the next step

Actual result:

ezgif com-video-to-gif

Expected result:

If user performs a step on onboarding screen, switching back should auto proceed to the next step

Reproduces how often:

Easy

Brave version (brave://version info)

All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    All

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @rossmoody @cezaraugusto @rebron

@srirambv srirambv added suggestion design A design change, especially one which needs input from the design team about-pages/welcome QA/Yes release-notes/exclude labels Jan 24, 2019
@srirambv srirambv added this to the 1.x Backlog milestone Jan 24, 2019
@btlechowski
Copy link

Reproduced on Windows 7 x64

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows

@kjozwiak
Copy link
Member

Noticed this as well a few days ago but forgot to file an issue for it :( The only one that works and moves to the next one is the Import screen. Opening it via the Import button opens chrome://settings/importData and than switches to Settings when going back to brave://welcome.

Definitely not a blocker but would be a nice to have. It's not a regression as the older brave://welcome implementation did the same thing.

@cezaraugusto cezaraugusto self-assigned this Jan 26, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@cezaraugusto
Copy link
Contributor

@srirambv onboarding flow changed a bit since this bug. Could you confirm issue persists?

@bsclifton
Copy link
Member

Closing as stale. Let's re-open if it's still an issue. Thanks!

@bsclifton bsclifton added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
about-pages/welcome closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude suggestion
Projects
None yet
Development

No branches or pull requests

6 participants