Follow up to #22203: Fix custom Brave notification ads should be attached to the browser window

[btlechowski]

Follow up to #22203. Thanks to @stephendonner for catching this on macOS

Steps to Reproduce

1. Clean install
2. Run Brave with: --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --brave-ads-staging --rewards=staging=true --variations-server-url=https://v --enable-features="CustomAdNotifications:should_attached_ad_notification_to_browser_window/true"
3. Enable rewards and ads
4. Trigger a notification ad
5. Make another application active

Note: use --enable-features="CustomNotificationAds for 1.53.x

Actual result:

Notification ad is not anchored to the browser window, the ad stays on top

Expected result:

Notification ad is anchored to the browser window

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave	1.53.62 Chromium: 114.0.5735.26 (Official Build) nightly (64-bit)
Revision	7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS	Ubuntu 18.04 LTS

cc @tmancey @aseren

[btlechowski]

Reproduced on Windows

Brave	1.52.109 Chromium: 114.0.5735.26 (Official Build) beta (64-bit)
Revision	7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS	Windows 10 Version 22H2 (Build 19045.2965)

[stephendonner]

Also experienced this on macOS using

Brave	1.52.108 Chromium: 114.0.5735.26 (Official Build) beta (x86_64)
Revision	7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS	macOS Version 11.7.7 (Build 20G1345)

Launched using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --brave-ads-staging --rewards=staging=true --variations-server-url=https://v --enable-features="CustomAdNotifications:should_attached_ad_notification_to_browser_window/true"

[LaurenWags]

fwiw, I have a dual monitor set up. the custom ad notification is shown on my main monitor screen while I have Brave open on my secondary monitor. Would that be changed when this is resolved?

[aseren]

There were lots of changes that happened with feature naming.

For Beta 1.52x the attached notification parameter name was changed to should_attach_ad_notification_to_browser_window here:
brave/brave-core#18076

For Nightly parameter was renamed to use_same_z_order_as_browser_window and set to true by default. So there is no need to set it through the command line.

The attached custom notifications do not work for Linux for now. This should be fixed here: #29744

cc @btlechowski @stephendonner

[aseren]

fwiw, I have a dual monitor set up. the custom ad notification is shown on my main monitor screen while I have Brave open on my secondary monitor. Would that be changed when this is resolved?

@LaurenWags, yes. The attached custom notification should fix this issue.