Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable New text in More tools -> Performance flyout menu #30173

Closed
stephendonner opened this issue May 5, 2023 · 2 comments · Fixed by brave/brave-core#18443
Closed

Unreadable New text in More tools -> Performance flyout menu #30173

stephendonner opened this issue May 5, 2023 · 2 comments · Fixed by brave/brave-core#18443

Comments

@stephendonner
Copy link

stephendonner commented May 5, 2023

Description

Unreadable New text in More tools -> Performance flyout menu

Steps to Reproduce

  1. install 1.52.85
  2. launch Brave
  3. open app menu -> More tools
  4. look at the Performance New text

Actual result:

Light Dark
image image

Expected result:

Readable New text, regardless of theme/Brave colors choices

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.52.85 Chromium: 113.0.5672.63 (Official Build) beta (64-bit)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS Windows 10 Version 22H2 (Build 19045.2913)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @brave/qa-team @aguscruiz @mkarolin

@aguscruiz
Copy link

aguscruiz commented May 5, 2023

Added designs here:

https://www.figma.com/file/tU9zrk9Ite8B06JSjHAHhn/General-dialogs-and-popups?node-id=21%3A26871&t=Sr1UlwXeY8eZfpFl-1

image

image

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.53.45 Chromium: 114.0.5735.26 (Official Build) nightly (x86_64)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS macOS Version 11.7.6 (Build 20G1231)
Dark Light
Screen Shot 2023-05-16 at 6 36 50 PM Screen Shot 2023-05-16 at 6 37 11 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants