Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating tab groups with tab-groups-save flag in incognito ends in crash #29938

Closed
sangwoo108 opened this issue Apr 22, 2023 · 3 comments
Closed

Creating tab groups with tab-groups-save flag in incognito ends in crash #29938

sangwoo108 opened this issue Apr 22, 2023 · 3 comments
Assignees
@sangwoo108
Labels
bug Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/tabs-bar OS/Desktop

Comments

@sangwoo108
Copy link

sangwoo108 commented Apr 22, 2023 •
edited
Loading

Description

original report #24717 (comment)
reporter @Emi-TheDhamphirInLoveUnderTheFrozenStar

Steps to Reproduce

  • Enable tab-groups-save flag
  • Open incognito window
  • Create a group

Actual result:

Crash

Expected result:

Shouldn't crash

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@sangwoo108 sangwoo108 self-assigned this Apr 22, 2023
@sangwoo108
Copy link
Author

This seems to happen on horizontal tab strip as well.

@sangwoo108
Copy link
Author

Looks like it's upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1434880

Will be fixed when we rebase.

@sangwoo108 sangwoo108 added bug Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix labels May 12, 2023
@ghost ghost mentioned this issue Jul 4, 2023
Closed
@sangwoo108
Copy link
Author

Upstream bug is marked as fixed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
bug Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/tabs-bar OS/Desktop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sangwoo108