Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical tab strip doesn't expand on Windows / And tabs are wider than it should be #29937

Closed
sangwoo108 opened this issue Apr 22, 2023 · 2 comments · Fixed by brave/brave-core#18204

Comments

@sangwoo108
Copy link

sangwoo108 commented Apr 22, 2023

Description

Original report: #24717 (comment)
Reporter: @Emi-TheDhamphirInLoveUnderTheFrozenStar

Steps to Reproduce

In Windows - 1.52.5 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit).

This is what happens when you attach/re-attach tabs from another window. The issue happens on both collapsed (which I usually use) and float mode.

2023-03-30_13-28-34

As you can see, it displays some of the title of the tab,

2023-03-30_13-44-23

Actual result:

Reattaching should expand the vertical tab strip

reference: screen recording in brave/brave-core#17690

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@sangwoo108
Copy link
Author

sangwoo108 commented Apr 22, 2023

@MadhaviSeelam Could you help me with finding out steps-to-reproduce for this? I think I've seen this before but not sure how it could be reproduced.


[Update] I think I found it. Thanks

@sangwoo108 sangwoo108 changed the title Vertical tab strip doesn't expand during drag and drop session on Windows Vertical tab strip doesn't expand on Windows / And tabs are wider than it should be Apr 24, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 26, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented May 5, 2023

Verification PASSED using

Brave | 1.52.87 Chromium: 113.0.5672.77 (Official Build) beta (64-bit)
-- | --
Revision | c4236862955e005c2187105415ac4a2ecf86dff1-refs/branch-heads/5672_62@{#3}
OS | Windows 11 Version 22H2 (Build 22621.1555)
  1. Installed 1.52.87
  2. launched Brave
  3. opened few tabs
  4. right clicked on a tab to open context menu
  5. selected Use vertical tabs
  6. clicked Minimize tabs button to enable Float on mouseover mode
  7. pressed down a tab before the vertical tab strip is expanded before releasing the mouse
  8. drag a tab to another window and drop

Confirmed tabs are as wide as vertical tab panel

Confirmed when dragging a tab into another window and drop, the tab strip stayed open if mouse is over tab strip.

example example
2023-05-05_14h43_25 !image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment