Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual test run on macOS (Intel) for 1.50.x - Release #3 #29736

Closed
30 of 36 tasks
kjozwiak opened this issue Apr 14, 2023 · 2 comments
Closed
30 of 36 tasks

Manual test run on macOS (Intel) for 1.50.x - Release #3 #29736

kjozwiak opened this issue Apr 14, 2023 · 2 comments

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Apr 14, 2023

Installer

  • Check signature:
    • If macOS, using x64 binary run spctl --assess --verbose for the installed version and make sure it returns accepted
    • If macOS, using universal binary run spctl --assess --verbose for the installed version and make sure it returns accepted
    • If Windows right click on the brave_installer-x64.exe and go to Properties, go to the Digital Signatures tab and double click on the signature. Make sure it says "The digital signature is OK" in the popup window

Widevine

  • Verify Widevine Notification is shown when you visit Netflix for the first time
  • Test that you can stream on Netflix on a fresh profile after installing Widevine
  • If macOS, run the above Widevine tests for both x64 and universal builds

Rewards

  • Verify that you are able to successfully join Rewards on a fresh profile

TLS Pinning

Update tests

  • Verify visiting brave://settings/help triggers update check
  • Verify once update is downloaded, prompts to Relaunch to install update

Upgrade

  • Make sure that data from the last version appears in the new version OK
  • Ensure that brave://version lists the expected Brave & Chromium versions
  • With data from the last version, verify that
    • Bookmarks on the bookmark toolbar and bookmark folders can be opened
    • Cookies are preserved
    • Installed extensions are retained and work correctly
    • Opened tabs can be reloaded
    • Stored passwords are preserved
    • Sync chain created in previous version is retained
    • Social media blocking buttons changes are retained
    • Custom filters under brave://settings/shields/filters are retained
    • Custom lists under brave://settings/shields/filters are retained
    • Rewards
      • BAT balance is retained
      • Auto-contribute list is retained
      • Both Tips and Monthly Contributions are retained
      • Panel transactions list is retained
      • Changes to rewards settings are retained
      • Ensure that Auto Contribute is not being enabled when upgrading to a new version if AC was disabled
    • Ads
      • Both Estimated pending rewards & Ad notifications received this month are retained
      • Changes to ads settings are retained
      • Ensure that ads are not being enabled when upgrading to a new version if they were disabled
      • Ensure that ads are not disabled when upgrading to a new version if they were enabled
@rebron
Copy link
Collaborator

rebron commented Apr 15, 2023

Verified PASSED using:

Brave 1.50.119 Chromium: 112.0.5615.121 (Official Build) (x86_64)
Revision 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS macOS Version 10.14.6 (Build 18G9323)
JavaScript V8 11.2.214.14
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36

@kjozwiak
Copy link
Member Author

Verification PASSED on macOS 13.2.1 x64 using the following build(s):

Ran through the Brave Rewards & Ads sections re: upgrading from 1.50.114 Chromium: 112.0.5615.49 -> 1.50.119 Chromium: 112.0.5615.121.

Brave | 1.50.119 Chromium: 112.0.5615.121 (Official Build) (x86_64)
--- | ---
Revision | 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS | macOS Version 13.2.1 (Build 22D68)

@kjozwiak kjozwiak self-assigned this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants