Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BR Panel momentarily flashes Welcome page before showing Rewards is off message #2958

Closed
srirambv opened this issue Jan 15, 2019 · 3 comments
Closed

BR Panel momentarily flashes Welcome page before showing Rewards is off message #2958

srirambv opened this issue Jan 15, 2019 · 3 comments
Labels
closed/invalid closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards

Comments

@srirambv
Copy link
Contributor

Description

BR Panel momentarily flashes Welcome page before showing Rewards is off message

Steps to Reproduce

  1. Clean profile on Linux
  2. Click the BR panel immediately after the browser is launched
  3. BR panel flashes the welcome message before showing the Rewards off message

Actual result:

BR Panel momentarily flashes Welcome page before showing Rewards is off message

Expected result:

Should not show the welcome message if rewards isn't enabled

Reproduces how often:

Easy on Linux but you have to be very quick in noticing it

Brave version (brave://version info)

Brave 0.60.13 Chromium: 72.0.3626.53 (Official Build) dev(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes on Dev build

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@brave/legacy_qa to verify on other platforms, @NejcZdovc
@srirambv srirambv added bug feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes release-notes/exclude labels Jan 15, 2019
@srirambv srirambv added this to the 1.x Backlog milestone Jan 15, 2019
@kjozwiak kjozwiak mentioned this issue Jan 15, 2019
Closed
@btlechowski
Copy link

Not reproducible on Windows 7 x64.

Brave 0.60.13 Chromium: 72.0.3626.53 (Official Build) dev (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows

@GeetaSarvadnya
Copy link

Not reproducible on windows 10 x64.

Brave 0.60.13 Chromium: 72.0.3626.53 (Official Build) dev (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 10

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@NejcZdovc
Copy link
Contributor

closing as stale

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 10, 2020
@NejcZdovc NejcZdovc added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed OS/Linux QA/Yes bug priority/P5 Not scheduled. Don't anticipate work on this any time soon. release-notes/exclude labels Apr 10, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/invalid closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bbondy @rebron @NejcZdovc @srirambv @btlechowski @GeetaSarvadnya