Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs jumps when selecting multiple tabs #29465

Closed
sangwoo108 opened this issue Apr 3, 2023 · 2 comments · Fixed by brave/brave-core#17876
Closed

Tabs jumps when selecting multiple tabs #29465

sangwoo108 opened this issue Apr 3, 2023 · 2 comments · Fixed by brave/brave-core#17876

Comments

@sangwoo108
Copy link

sangwoo108 commented Apr 3, 2023

Description

Original report: #24717 (comment)

Steps to Reproduce

  1. Create multiple tabs
  2. Select multiple tabs with shift + click - click a tab and then shift+click another tab below

Actual result:

The selected tabs jumps down and come back to their position

Expected result:

They shouldn't jump around

Reproduces how often:

Easily reproducible

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

The above requires 1.51.97 or higher for 1.50.x verification 👍

@stephendonner
Copy link

stephendonner commented Apr 21, 2023

Verification PASSED using

Followed the specific steps to reproduce for each case, below, from brave/brave-core#17876 (comment).

Steps:

  1. installed 1.51.99
  2. launched Brave
  3. set brave://flags/#brave-vertical-tabs to Enabled
  4. clicked Relaunch

Tab-jumping

(continued from Steps)
5. loaded a bunch of sites in tabs
6. context-clicked on a tab
7. chose Use vertical tabs
8. selected a few contiguous tabs using shift

Confirmed no more tab-jumping behavior, as seen below in 1.51.95

1.51.99 1.51.95
no-tab-jumping tab-jump-beta

Window-jumping

(continued from Steps)
5. loaded a bunch of sites in tabs
6. context-clicked on a tab
7. chose Use vertical tabs
8. selected the first and last tab, while holding shift to trigger contiguous selection

Confirmed no more window-jumping behavior, as seen below in 1.51.95

1.51.99 1.51.95
no-window-jumping window-jumping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants