Sync bookmark favicons across devices

[srirambv]

Description

Sync'd bookmarks doesn't retain favicon, adds it when the bookmark is loaded

Steps to Reproduce

1. Create sync chain and add two devices to it
2. Import bookmarks file on device 1
3. Wait till it sync's over to device 2, doesn't show any favicon, just has generic file icon

Actual result:

Sync'd bookmarks doesn't retain favicon, adds it when the bookmark is loaded

Expected result:

Should sync favicons as well

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.59.21 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	All

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Yes on beta

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
  No
• Is the issue reproducible on the latest version of Chrome?
  No

Additional Information

[rebron]

I'll check to see if this behavior with Chrome sync/Firefox sync?

[rebron]

This works properly with Chrome and Firfeox bookmark sync and favicons are imported over without having to visit each site.

[jsecretan]

Specifically tested this out on sync v2 and saw it working.

[btlechowski]

Verification passed on

Brave	1.12.102 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision	19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS	Ubuntu 18.04 LTS

Added Bookmark after sync:

Verified icon is synced when Bookmark was imported before sync chain
Verified icon is synced when Bookmark was imported after sync chain
Bookmarks used:
bookmarks_interia.html.txt

---

Verification passed on

Brave | 1.12.104 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)

• Verified the STR from the description and ensured that the synced bookmarks retain favicons in both devices
  
  
• Ensured bookmarks which are added before the sync chain are also showing up the favicons after sync between two devices
• Ensured import bookmarks from other browsers are also showing up the favicons
• Ensure import HTML file are also showing up the favicons

---

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.15.6 (Build 19G73)

macOS Catalina x64	Win 10 x64	Android 10 (S10+)

[srirambv]

Verification passed on OnePlus 6T and Samsung Tab A with Android 10 running 1.12.111 x63 build

• Verified bookmarks favicons is sync'd on all devices

Desktop bookmarks

Desktop	OnePlus 6T	Samsung Tab A

Mobile Bookmarks

Desktop	OnePlus 6T	Samsung Tab A