Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips not going through after the latest update #2937

Closed
DarkShimy00 opened this issue Jan 13, 2019 · 4 comments
Closed

Tips not going through after the latest update #2937

DarkShimy00 opened this issue Jan 13, 2019 · 4 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@DarkShimy00
Copy link

DarkShimy00 commented Jan 13, 2019

Description

Tips not going through after the last update.

Steps to Reproduce

  1. Try to tip a website or a YouTube video.
  2. Choose an amount (tested with 1, 5 and 10).
  3. Click on "send my tip".

Actual result:

screenshot
The button doesn't appear clickable, i.e. the cursor does not change.
The "thank you" pane correctly appears but the tip is not sent.

Expected result:

The cursor should change to a hand when hovering over "send my tip".
The tip should be sent.

Reproduces how often:

Always.

Brave version (brave://version info)

Brave: 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision: 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS: Windows 10

Reproducible on current release:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional Information

None.

@srirambv srirambv added needs-investigation A bug not 100% confirmed/fixed feature/rewards labels Jan 14, 2019
@srirambv srirambv added this to the 1.x Backlog milestone Jan 14, 2019
@NejcZdovc
Copy link
Contributor

for no cursor we have issue here #2744. When you say that tip doesn't go through what do you mean by that?

@DarkShimy00
Copy link
Author

The amount is not deduced in a timely manner or simply not at all. After restarting the browser a day later, some of my tips were not sent and I received an error message (forgot to write it down); but one was sent. I had enough BAT to send.

After trying again today, it appears to work correctly, perhaps it was a server issue on your side. The thing is, the user should not have to guess if it was sent or not. If it isn't sent immediately it should just pop an error message right away, rather than succeeding (or not) after a day.

@GeetaSarvadnya
Copy link

@LaurenWags
Copy link
Member

@DarkShimy00 you are correct, there was a server issue on our side.

Additionally, I agree with you that a user should not have to guess what's going on. We have this issue logged to improve the tipping error flow #2453

I'm going to close this issue for now, please do use the linked issue to follow the progress on improving the error flow for tipping.

@LaurenWags LaurenWags modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 14, 2019
@kjozwiak kjozwiak added closed/duplicate Issue has already been reported and removed feature/rewards needs-investigation A bug not 100% confirmed/fixed labels Jan 14, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

7 participants