Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a-c table not being updated correctly - follow up to 2882 #2911

Closed
LaurenWags opened this issue Jan 10, 2019 · 2 comments · Fixed by brave/brave-core#1760
Closed

a-c table not being updated correctly - follow up to 2882 #2911

LaurenWags opened this issue Jan 10, 2019 · 2 comments · Fixed by brave/brave-core#1760

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #2882

While testing above issue, found that if you visited a site in Dec 2018 (eg. DDG) and then again in 2019, your table still lists DDG twice. However, the % values in the table all add up to 100%.

Steps to Reproduce

  1. Have a rewards profile from Dec 2018 with some data in it
  2. Launch Brave with that profile in Jan 2019 (using 0.58.18)
  3. Visit some sites (one not in the list already and one in the list already)
  4. View A-C table
  5. % values started over at 100% for these two recently visited sites
  6. Close Brave, swap out .app file to be 0.58.21
  7. Visit one of the sites again.
  8. Go back to A-C table.
  9. All percentage values are back to normal (all add up to 100%) but the site which was already in the table is listed twice still.

Actual result:

Site is listed twice
screen shot 2019-01-10 at 6 25 10 pm

screen shot 2019-01-10 at 6 25 01 pm

Expected result:

Site only listed once

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@LaurenWags LaurenWags added this to the 1.x Backlog milestone Jan 10, 2019
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 15, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 21, 2019
@NejcZdovc
Copy link
Contributor

this one is currently blocked as we need to decide what we would like to do with monthly reports

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@NejcZdovc NejcZdovc added this to the 0.63.x - Nightly milestone Feb 25, 2019
@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 20, 2019

Verified passed with

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Verification passed on

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

Used test plan from brave/brave-core#1760
Also tested excluding and including of site in a-c table

Verification passed on

Brave 0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux
  • Verification passed from test plan
  • Verified by excluding and including site from a-c table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants