Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual test run on macOS (Intel) for 1.49.x - Release #28853

Closed
LaurenWags opened this issue Mar 2, 2023 · 1 comment
Closed

Manual test run on macOS (Intel) for 1.49.x - Release #28853

LaurenWags opened this issue Mar 2, 2023 · 1 comment

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Mar 2, 2023

Installer

  • Check the installer is close to the size of the last release
  • Check signature:
    • If macOS, using x64 binary run spctl --assess --verbose for the installed version and make sure it returns accepted
    • If macOS, using universal binary run spctl --assess --verbose for the installed version and make sure it returns accepted

About pages

  • Verify that both chrome:// and about:// forward to brave:// (run through several internal pages)

Adblock lists and filters

  • Navigate to brave://adblock and confirm you are redirected to brave://settings/shields/filters
  • Filter lists
    • Type "cookie" into the "Filter lists" search box, and verify that the list is filtered down to just the Easylist-Cookie List - Filter Obtrusive Cookie Notices
    • Enable the Easylist-Cookie List and refresh the page
    • Expand the regional filter lists and verify that the cookie list is still enabled
  • Add custom filter lists
    • Enter https://raw.githubusercontent.com/ryanbr/fanboy-adblock/master/fanboy-antifonts.txt into Enter filter list URL and press Add
    • Ensure that the Custom lists table appears, with the newly added entry; Last updated should be now (e.g. 0 seconds ago)
    • Refresh the page after a few seconds and ensure that the Last updated time reflects the time that has passed
    • Use the dropdown next to the entry and verify that all options (Update now, View source, Unsubscribe) are shown
      • Pressing the Update now button should update the timestamp appropriately
      • View source should open the text of the filter list
      • Unsubscribe should delete the entry from the list and hide the table once again
  • Add custom filter lists
    • The Create custom filters section should be visible with a text box and Save changes button
    • Adding text to the box, pressing Save changes, and refreshing the page should result in the same text appearing in the box after the reload

Importing

  • Verify that you can import History, Favorites/Bookmarks and Passwords from Google Chrome
  • Verify that you can import History, Favorites/Bookmarks, Passwords, Search Engines and Autofill from Firefox
  • Verify that you can import Favorites/Bookmarks from Microsoft Edge
  • Verify that importing bookmarks using Bookmark HTML File retains the folder structure on a clean profile

Context menus

  • Verify you can block a page element using Block element via selector context-menu item
  • Verify selecting Manage custom filters opens brave://adblock in a NTP
  • Verify removing the rule from brave://adblock reflects the change on the website, after reload

Extensions/Plugins

  • Verify pdfium, Torrent viewer extensions are installed automatically on fresh profile and cannot be disabled (they don't show up in brave://extensions)
  • Verify older version of an extension gets updated to new version via Google server
  • Verify that magnet links and .torrent files correctly open WebTorrent and you're able to download the file(s)

IPFS

  • Load vitalik.eth. Click on Proceed using Infura server. Click on Use a Brave local IPFS node. Verify the content loads from ipfs://bafybeigsn4u4nv4uyskxhewakk5m2j2lluzhsbsayp76zh7nbqznrxwm7e/.

Chrome Web Store (CWS)

PDF

Widevine

  • Verify Widevine Notification is shown when you visit Netflix for the first time
  • Test that you can stream on Netflix on a fresh profile after installing Widevine
  • Verify Widevine Notification is shown when you visit HBO Max for the first time
  • Test that you can stream on HBO Max on a fresh profile after installing Widevine
  • If macOS, run the above Widevine tests for both x64 and universal builds

Geolocation

Crash Reporting

  • Check that loading brave://crash & brave://gpucrash causes the new tab to crash
  • Check that brave://crashes lists the Uploaded Crash Report ID once the report has been submitted
  • Verify the crash ID matches the report on Backtrace using _rxid equal [ value ]

Bravery settings

  • Verify that HTTPS Everywhere works by loading http://https-everywhere.badssl.com/
  • Turning HTTPS Everywhere off and Shields off both disable the redirect to https://https-everywhere.badssl.com/
  • Verify that toggling Trackers & ads blocked works as expected
  • Visit https://testsafebrowsing.appspot.com/s/phishing.html, verify that Safe Browsing (via our Proxy) works for all the listed items
  • Visit https://www.blizzard.com and then turn on script blocking, page should not load.
  • Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/9/ when 3rd party cookies are blocked and not blank when 3rd party cookies are unblocked
  • Test that https://mixed-script.badssl.com/ shows up as grey not red (no mixed content scripts are run)
  • In brave://settings/security, choose a DNS provider from the providers listed under Use secure DNS, load https://browserleaks.com/dns, and verify your ISP's DNS resolvers aren't detected and shown; only your chosen DoH provider should appear.
  • Open a New Private Window with Tor, load https://browserleaks.com/dns, and verify your ISP's DNS resolvers aren't detected and shown.

TLS Pinning

Fingerprint Tests

Brave Ads

  • Verify when you enable Rewards from panel or brave://rewards, Ads are enabled by default
  • Verify Ads UI (panel, settings, etc) shows when in a region with Ads support
  • Verify Ads UI (panel, settings, etc) does not show when in a region without Ads support. Verify the Ads panel does show the 'Sorry! Ads are not yet available in your region.' message.
  • Verify when the system language is English, the Browser language is French, and you are in one of the supported regions, Ad notifications are still served to you.
  • Verify you are served Ad notifications when Ads are enabled
    • Verify ad earnings are reflected in the rewards widget on the NTP.
  • Verify when Ads are toggled off, there are no Ad messages in the logs
  • Verify when Rewards are toggled off (but Ads were not explicitly toggled off), there are no Ads logs recorded
  • Verify view/click/dismiss/landed ad notifications show in confirmations.json
  • Verify pages you browse to are being classified in the logs
  • Verify tokens are redeemed by viewing the logs (you can use --rewards=debug=true to shorten redemption time)
  • Verify Ad is not shown if a tab is playing media and is only shown after it stops playing

Rewards

  • Verify that none of the reward endpoints are being contacted when a user visits a media creator (youtube.com, reddit.com, twitter.com, github.com) and hasn't joined rewards
    • Verify that rewards.brave.com, pcdn.brave.com, grant.rewards.brave.com or api.rewards.brave.com are not being contacted
  • Verify you are able to create a new Rewards profile and are in the unverified state by default
    • Verify when you visit a creator in this state the panel shows a prompt to connect a custodian and no BAT information (earnings, balance, etc) is displayed
    • Verify when you click on an in-line tip button in this state, the tip banner indicates you must connect a custodian
    • Verify when you view the NTP widget in this state it shows a prompt to connect a custodian and no BAT information (earnings, balance, etc) is displayed
    • Verify when you visit brave://rewards in this state there are no Auto Contribution, Tipping, or summary panels on this page
    • Verify you can toggle ads off/on from this page and the panel and NTP widget respond accordingly
    • Verify you can toggle rewards off/on from the panel and the brave://rewards page and NTP widget respond accordingly
  • Verify you are able to connect a custodian
    • Verify Rewards balance shows correct BAT and USD value on brave://rewards, panel, and NTP widget after you connect
    • Verify when you click on the BR panel while on a site, the panel displays site-specific information (site favicon, domain, attention %)
    • Verify BR panel and tip banner shows message about an unverified creator
    • Verify BR panel and tip banner shows message about a creator with a different custodian
    • Verify you are able to tip a creator who has the same custodian as you
    • Verify you are able to perform an auto contribution
    • Verify if you disable auto-contribute you are still able to tip creators
    • Verify if auto-contribute is disabled AC does not occur
    • Verify that there is no "Disconnect" option once connected to a custodian
  • Verify that you are able to reset rewards
    • Verify after rewards are reset, the panel, brave://rewards page, and NTP widget to back to the unverified state

Social-media blocking settings

  • Verify individual Social media blocking buttons works as intended when enabled/disabled by visiting https://fmarier.github.io/brave-testing/social-widgets.html
  • visit brave://settings/privacy -> Site and Shields Settings -> Cookies and site data and ensure that
    • both https://[*.]firebaseapp.com & https://accounts.google.com are added into Sites that can always use cookies when Allow Google login buttons on third party sites is enabled
    • both https://[*.]firebaseapp.com & https://accounts.google.com are removed from Sites that can always use cookies when Allow Google login buttons on third party sites is disabled
  • ensure that you can log in into https://www.expensify.com while Allow Google login buttons on third party sites is enabled
  • ensure that once Allow Google login buttons on third party sites has been disabled, you can't log in into https://www.expensify.com

Sync

  • Verify you are able to create a sync chain and add a mobile/computer to the chain
  • Verify you are able to join an existing sync chain using code words
  • Verify the device name is shown properly when sync chain is created
  • Verify you are able to add a new mobile device to the chain via QR code/code words
  • Verify newly created bookmarks get sync'd to all devices on the sync chain
  • Verify existing bookmarks on current profile gets sync'd to all devices on the sync chain
  • Verify folder structure is retained after sync completes
  • Verify bookmarks don't duplicate when sync'd from other devices
  • Verify removing bookmark from device gets sync'd to all devices on the sync chain
  • Verify adding/removing a bookmark in offline mode gets sync'd to all devices on the sync chain when device comes online
  • With only two devices in chain, verify removing the other device resets the sync on b-c as well

Tor Tabs

Cookie and Cache

  • Go to http://samy.pl/evercookie/ and set an evercookie. Check that going to prefs, clearing site data and cache, and going back to the evercookie site does not remember the old evercookie value

Chromium/Brave GPU

  • Verify that brave://gpu (Brave) matches chrome://gpu (Chrome) when using the same Chromium version

Startup & Components

  • Verify that Brave is only contacting *.brave.com endpoints on first launch using either Charles Proxy, Fiddler, Wireshark or LittleSnitch (or a similar application)
    • Verify that opening a NTP doesn't trigger any outbound connections related to widgets without user interaction
  • Remove the following component folders and ensure that they're being re-downloaded after restarting the browser:
    • afalakplffnnnlkncjhbmahjfjhmlkal: AutoplayWhitelist.dat, ExtensionWhitelist.dat, ReferrerWhitelist.json and Greaselion.json
    • CertificateRevocation
    • cffkpbalmllkdoenhmdmpbkajipdjfam: rs-ABPFilterParserData.dat & regional_catalog.json (AdBlock)
    • gccbbckogglekeggclmmekihdgdpdgoe: (Sponsored New Tab Images)
    • jicbkmdloagakknpihibphagfckhjdih: speedreader-updater.dat
    • oofiananboodjbbmdelgdommihjbkfag: HTTPSE
    • Safe Browsing
  • Restart the browser, load brave://components, wait for 8 mins and verify that no component shows any errors

Note: Always double check brave://components to make sure there's no errors/missing version numbers

Session storage

  • Temporarily move away your browser profile and test that a new profile is created on browser relaunch
    • macOS - ~/Library/Application\ Support/BraveSoftware/
    • Windows - %userprofile%\appdata\Local\BraveSoftware\
    • Linux(Ubuntu) - ~/.config/BraveSoftware/
  • Test that both windows and tabs are being restored, including the current active tab
  • Ensure that tabs are being lazy loaded when a previous session is being restored

Upgrade

  • Make sure that data from the last version appears in the new version OK
  • Ensure that brave://version lists the expected Brave & Chromium versions
  • With data from the last version, verify that:
    • Bookmarks on the bookmark toolbar and bookmark folders can be opened
    • Cookies are preserved
    • Installed extensions are retained and work correctly
    • Opened tabs can be reloaded
    • Stored passwords are preserved
    • Sync chain created in previous version is retained
    • Social media-blocking buttons changes are retained
    • Custom filters under brave://settings/shields/filters are retained
    • Custom lists under brave://settings/shields/filters are retained
    • Rewards
      • BAT balance is retained
      • Auto-contribute list is retained
      • Both Tips and Monthly Contributions are retained
      • Panel transactions list is retained
      • Changes to rewards settings are retained
      • Ensure that Auto Contribute is not being enabled when upgrading to a new version if AC was disabled
    • Ads
      • Both Estimated pending rewards & Ad notifications received this month are retained
      • Changes to ads settings are retained
      • Ensure that ads are not being enabled when upgrading to a new version if they were disabled
      • Ensure that ads are not disabled when upgrading to a new version if they were enabled
@LaurenWags LaurenWags added this to the 1.48.x - Release #6 milestone Mar 2, 2023
@LaurenWags LaurenWags changed the title Manual test run on macOS (Intel) for 1.48.x - Release #6 Manual test run on macOS (Intel) for 1.49.x - Release Mar 2, 2023
@LaurenWags LaurenWags modified the milestones: 1.48.x - Release #6, 1.49.x - Release Mar 2, 2023
@stephendonner stephendonner self-assigned this Mar 7, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.49.120 Chromium: 111.0.5563.64 (Official Build) (x86_64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 11.7.4 (Build 20G1120)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants