Upgrade from Chromium 111.0.5563.41 to Chromium 111.0.5563.50

[emerick]

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/111.0.5563.41..111.0.5563.50?pretty=fuller&n=10000

QA tests:

• Check branding items
• Check for version bump

Additional checks:

• No specific code changes in Brave (only line number changes in patches)

[kjozwiak]

The above requires 1.49.117 or higher for 1.49.x verification 👍

[kjozwiak]

Quick update re: the work that remains on each platform/OS in terms of checking/verifying C111:

Still requires a check re: affected C111 areas

• macOS x64 - Affected areas mentioned via Upgrade from Chromium 110 to Chromium 111 #28288 (comment) need to be checked/verified
• Linux - Affected areas mentioned via Upgrade from Chromium 110 to Chromium 111 #28288 (comment) need to be checked/verified
• Android Tablet - Affected areas mentioned via Upgrade from Chromium 110 to Chromium 111 #28288 (comment) need to be checked/verified

Affected C111 areas completed and require a quick spot check of 111.0.5563.41

• Win x64 - Just needs a simple spot check re: 111.0.5563.41 on 1.49.x as the affected areas where checked via Upgrade from Chromium 110 to Chromium 111 #28288 (comment) & Upgrade from Chromium 110 to Chromium 111 #28288 (comment).
• Android ARM - Just needs a simple spot check re: 111.0.5563.41 on 1.49.x as the affected areas where checked via Upgrade from Chromium 110 to Chromium 111 #28288 (comment).

[MadhaviSeelam]

Verification PASSED using

Brave | 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
-- | --
Revision | 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS | Windows 11 Version 22H2 (Build 22621.1265)

[LaurenWags]

Verification in progress with

Brave | 1.49.118 Chromium: 111.0.5563.50 (Official Build) (x86_64)
-- | --
Revision | 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS | macOS Version 12.6.3 (Build 21G419)

Verified desktop affected areas as listed under #28288 (comment).

Verify functionality/UI for tabs and tab groups, in regular orientation and "vertical tabs" orientation - PASSED

regular orientation:

• Confirmed that user can create a new tab group via Add tab to group ->New group
• Confirmed that tabs can be added to existing/already created tab groups
• Confirmed that click on the tab group name expands/list of all the tabs added in that group
• Confirmed that added tabs can be removed from the tab group via Remove from group
• Confirmed that user can ungroup the tabs via Ungroup
• Generally spot checked various right click context menu options on tabs such as:
  • pin/unpin
  • mute/unmute
  • Close, Close other tabs, Close tabs to the right and Reopen closed tab
  • Bookmark All
  • Reload
  • Duplicate
  • New tab to the right
  • Add a tab to new group

Example	Example	Example	Example

Vertical tabs orientation:

• Confirmed that vertical tabs can be enabled via the flag #brave-vertical-tabs
• After enabling the flag, right click on any tab and select Use vertical tabs option to view vertical tabs
• Verified that sites can be added to vertical tab by clicking on the + New tab
• Generally spot checked various right click context menu options on vertical tabs such as:
  • pin/unpin
  • mute/unmute
  • Close, Close other tabs, Close tabs to the right and Reopen closed tab
  • Bookmark All
  • Reload
  • Duplicate
  • New tab to the right
  • Add a tab to new group
• Right click on the sites in vertical tab and select Add a tab to new group and then created tab (e.g first group which I have created in my testing) group and ensured that sites got added to the tab group first group
• Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown
• Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
• Ensured that tabs can be drag and drop in an vertical tab
• Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs

Example	Example	Example	Example	Example	Example	Example	Example	Example	Example

brave://settings - PASSED

• Verified that click on settings in brave://settings redirected to the intended page (spot checked this across the various sections: Get Started, Appearance, etc)
• Verified the brave://settings UI and ensured UI looks good
• Verified the icons in the brave://settings page and ensured icons are shown as expected in each settings page
• Generally spot checked various settings to confirm they worked as expected

Sidebar - PASSED

• Confirmed that sidebar is not shown by default in the release channel
• Confirmed that Reading list icon is added to the sidebar menu
• Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
• Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
• Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
• Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
• Confirmed that reading list icon is shown in the URL bar, next to wallet icon
• Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
• Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
• Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
• Confirmed that sites can be segregated to Read and Unread list
• Confirmed that sites can be deleted from the reading list

Example	Example	Example	Example

brave://welcome shows as expected - PASSED

Confirmed brave://welcome displays on new installs of 1.49.118.
Confirmed able to complete onboarding on brave://welcome (spot check of functionality including setting as default, importing, and allowing crash reports/P3A).

Example	Example	Example

Setting Brave as default browser continues to work as expected - PASSED

Confirmed able to

• Set Brave as default browser via onboarding brave://welcome page
• Set Brave as default browser via Set as a default infobar in NTP
• Set Brave as default browser via Make default in `brave://settings

Example	Example	Example	Example

Ephemeral storage - PASSED (no cookie/content checks)

Step 1: Encountered #26817

• Test results are not same as the test page results, encountered Issue with Ephemeral Storage tests  #26817, looks like this is expected as per Issue with Ephemeral Storage tests  #26817 (comment), but confirming via https://bravesoftware.slack.com/archives/C7VLGSR55/p1678224521088549?thread_ts=1668620091.590189&cid=C7VLGSR55

Default - cross site cookies blocked, ephemeral storage enabled

Step 1	Step 2	Step 3	Step 4	Step 5	Step 6

All cookies blocked, ephemeral storage enabled

Step 1	Step 2	Step 3	Step 4	Step 5	Step 6

All cookies allowed, ephemeral storage enabled

Step 1	Step 2	Step 3	Step 4	Step 5	Step 6

[Uni-verse]

Verified on Samsung GS 21 5G using version(s):

Brave	1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit) 
Revision	39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS	Android 13; Build/TP1A.220624.014

• Version bump
• Branding
• Spot checked affected areas mentioned in Upgrade from Chromium 110 to Chromium 111 #28288 (comment)

[LaurenWags]

Changing to QA/No and release-notes/exclude as this is superseded by #28922

[btlechowski]

Verification passed on

Brave	1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision	39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS	Ubuntu 18.04 LTS

Verified test plan from #28288 (comment)

Verify functionality/UI for tabs and tab groups, in regular orientation and "vertical tabs" orientation - PASSED

regular orientation:

• Confirmed that user can create a new tab group via Add tab to group ->New group
  

• Confirmed that tabs can be added to existing/already created tab groups
  

• Confirmed that click on the tab group name expands/list of all the tabs added in that group

Example	Example

• Confirmed that added tabs can be removed from the tab group via Remove from group
  

• Confirmed that user can ungroup the tabs via Ungroup
  

Vertical tabs orientation:

• Confirmed that vertical tabs can be enabled via the flag #brave-vertical-tabs
• After enabling the flag, right click on any tab and select Use vertical tabs option to view vertical tabs
• Verified that sites can be added to vertical tab by clicking on the + New tab
• Right click on any site added in the vertical tab shows the tab context menu options
• Verified that reading list and vertical tabs cab be enabled at the same time
• Right click on any site and select New tab to the right context menu option and ensured new tab got added to the right
• Right click on any site and select Add tab to reading list context menu option and ensured site can be added to the reading list
• Right click on any site and select Add a tab to new group and ensured that the selected site can be added to new tab group
• Right click on the sites in vertical tab and select Add a tab to new group and then created tab (e.g test which I have created in my testing) group and ensured that sites got added to the tab group test
• Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown
• Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
• When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine
• Right click on any site in vertical tab and select Reload context menu option and ensured site gets reloaded/refreshed
• Right click on any site in vertical tab and select Duplicate context menu option and ensured duplicate tab got added to the tab group
• Right click on any site in vertical tab and select Pin context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured Unpin option is shown
• Ensured that pinned site can be unpinned by clicking on the Unpin option
• Right click on any YT site in vertical tab and select mute context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode.
• Ensured that YT videos can be unmuted by clicking on the Unmute option
• Ensured that Close, Close other tabs, Close tabs to the right and Reopen closed tabs works as expected
• Ensured that the tab Bookmarls all context menu works as expected
• Ensured that tabs can be drag and drop in an vertical tab
• Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs

brave://settings - PASSED

• Ensured that no new settings are added as part of CR 111
• Verified that click on each settings in brave://settings redirected to the intended page
• Verified the brave://settings UI and ensured UI looks good
• Verified the icons in the brave://settings page and ensured icons are shown as expected in each settings page

PDF extension - PASSED

• Ensured that PDF loaded over HTTPS at https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf
• Ensured that PDF loaded over HTTP at http://www.pdf995.com/samples/pdf.pdf
• Ensured that the PDF's can be downloaded
• Ensured taht the downloaded PDF's can be opened from system local file path

Sidebar - PASSED

• Confirmed that Reading list icon is added to the sidebar menu
• Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
• Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
• Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
• Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
• Confirmed that reading list icon is shown in the URL bar, next to wallet icon
• Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
• Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
• Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
• Confirmed that sites can be segregated to Read and Unread list
• Confirmed that sites can be deleted from the reading list

Ephemeral storage and cookie/content settings in general - PASSED

Ephemeral storage

Ephemeral storage - cross site cookies blocked, ephemeral storage enabled - PASSED

Step 1: Encountered #26817

• Test results are not same as the test page results, encountered Issue with Ephemeral Storage tests  #26817, looks like this is expected as per Issue with Ephemeral Storage tests  #26817 (comment)
  

Step 2: works as expected

Step 3: works as expected

Step 4: works as expected

Step 5: works as expected

Step 6: works as expected

Ephemeral storage - All cookies blocked, ephemeral storage enabled _PASSED

Step 1:

Step 2: works as expected

Step 3: works as expected

Step 4: works as expected

Step 5: works as expected

Step 6: works as expected

Content settings:

Content settings - PASSED

• Confirmed that Shields settings is been added in brave://settings/content (more info: Add Brave's Shields setting to brave://settings/content #12782)
• Added few sites to shields up and shields down list and ensured sites got added to shield settings list
• Open the sites (which are added in shield down list) in PT/TOR tab windows and ensured shields are down as expected
• Confirmed content settings are working as expected
• Confirmed cookies settings are working as expected

1. Block cookies content settings

• Open a site cnn.com
• Open content settings for cnn.com
• Block content settings for Location and Window management
• Reload cnn.com
• Ensured that Location and Window management permission are blocked for cnn.com
• Open brave://settings/cookies and Block all cookies
• Reload cnn.com and ensured that all cookies are blocked on cnn.com

2. Block scripts content settings

• Block the java scripts for a site via brave://settings/content/javascript
• Open the site ensured Java scripts blocked for the site
• Open a bunch of websited and ensured java script is not blocked

3. Block autoplay global settings

• Block the youtube.com autoplay content global settings via brave://settings/content/autoplay
• Open youtube.com and ensured no videos are autoplayed
• Click on a video and play the video manully, wait till the 1st video ends
• Ensured 2nd video is not autoplayed

Verify that Brave policies (such as TorDisabled) work correctly when set - PASSED

Used #25151

Brave Sync - PASSED

• Verified Brave Sync in Manual test run on Win x64 for 1.50.x - Nightly (Checking C111) #28714

Verified able to create sync chain and that data was synced
||

Verify that welcome page continues to show when expected - PASSED

• Verified various supported browsers and the functionality is working as expected

Example	Example	Example	Example

Verify that setting Brave as default browser continues to work as expected - PASSED

• Set Brave as default browser via onboarding brave://welcome page
• Set Brave as default browser via Set as a default infobar in NTP
• Set Brave as default browser via Make default in brave://settings

Example	Example	Example	Example

[stephendonner]

Verification PASSED using

Brave	1.49.120 Chromium: 111.0.5563.64 (Official Build) (x86_64)
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	macOS Version 13.3 (b) (Build 22E7752300g)

Content settings - PASSED

• Confirmed that Shields settings is been added in brave://settings/content (more info: Add Brave's Shields setting to brave://settings/content #12782)
• Added few sites to shields up and shields down list and ensured sites got added to shield settings list
• Open the sites (which are added in shield down list) in PT/TOR tab windows and ensured shields are down as expected
• Confirmed content settings are working as expected
• Confirmed cookies settings are working as expected

1. Block cookies content settings - PASSED

• Open a site cnn.com
• Open content settings for cnn.com
• Block content settings for Location and Window management
• Reload cnn.com
• Ensured that Location and Window management permission are blocked for cnn.com
• Open brave://settings/cookies and Block all cookies
• Reload cnn.com and ensured that all cookies are blocked on cnn.com

Example	Example	Example	Example	Example	Example

2. Block scripts content settings - PASSED

• Block the JavaScript for a site via brave://settings/content/javascript
• Open the site ensured JavaScript blocked for the site
• Open a bunch of websites and ensured JavaScript is not blocked

Example	Example	Example	Example

3. Block autoplay global settings - PASSED

• Block the youtube.com autoplay content global settings via brave://settings/content/autoplay
• Open youtube.com and ensured no videos are autoplayed
• Click on a video and play the video manully, wait till the 1st video ends
• Ensured 2nd video is not autoplayed

Example	Example	Example	Example

Verify that Brave policies (such as TorDisabled) work correctly when set - PASSED

1. installed 1.49.120
2. launched Brave
3. pasted defaults write com.brave.Browser TorDisabled -bool true into a Terminal/console window, and pressed return
4. launched Brave
5. confirmed that the New Private Window with Tor menu option is removed
6. opened brave://policies
7. confirmed the correct entry for TorDisabled set to true is reflected
8. shut down Brave
9. pasted defaults delete com.brave.Browser TorDisabled
10. launched Brave
11. confirmed New Private Window with Tor menu option returned

Example	Example	Example	Example	Example