Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console doesn't capture any log for ads #2871

Closed
GeetaSarvadnya opened this issue Jan 9, 2019 · 9 comments
Closed

Console doesn't capture any log for ads #2871

GeetaSarvadnya opened this issue Jan 9, 2019 · 9 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 9, 2019

Description

Console doesn't capture any log for ads

Steps to Reproduce

  1. Clean profile 0.60.9
  2. Launch brave via console
  3. Enable Ads switch from rewards page
  4. Check ads notifications (Ads notifications are received)

Actual result:

Console doesn't capture any log for ads

Expected result:

Console should capture all logs

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.60.9 Chromium: 72.0.3626.28 (Official Build) dev (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows

Reproducible on current release:na

  • Does it reproduce on brave-browser dev/beta builds? yes on Dev build

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? na
  • Is the issue reproducible on the latest version of Chrome? na

Additional Information

@brave/legacy_qa

@GeetaSarvadnya GeetaSarvadnya added this to the 1.x Backlog milestone Jan 9, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Jan 9, 2019

@GeetaSarvadnya can you please include the exact commands/variables that you're launching Brave with? This way, whoever takes a look at this will have more details.

@tmancey
Copy link
Contributor

tmancey commented Jan 9, 2019

@GeetaSarvadnya is this still an issue as I believe this was related to not use the command-line arg for diagnostic logging?

@GeetaSarvadnya
Copy link
Author

@tmancey If i use --enable-logging=stderr, I am getting error logs on console. Now i am not getting ads notifications, tomorrow i will check again and post console error logs.

@btlechowski
Copy link

btlechowski commented Jan 14, 2019

I get ads notification logs on Windows 7 x64 and Windows 10 x64, Brave 0.60.13. My command line arg is:
./brave.exe --enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-staging --brave-ads-debug --brave-ads-testing

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jan 15, 2019

@tmancey Case1: I am not getting adds notification on Windows 10 x64 when i use below command-line arg:

BraveSoftware/Brave-Browser-Dev/Application/brave.exe --enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-staging --brave-ads-debug --brave-ads-testing
Console Logs:
image
Ads_service folder has only one file client.json
image
Build : 0.60.12

Case2: I am getting ads notification on Windows 10 x64 when i use below command-line arg:
BraveSoftware/Brave-Browser-Dev/Application/brave.exe --enable-logging --vmodule=brave_ads=3 --brave-ads-staging --brave-ads-debug --brave-ads-testing
Console log:
image
Ads_service folder has all the files:
image
Build: 0.60.12

Ads event logs are getting captured in chrome_debug.log

image

In both case1 and case2, console doesn't show any ads related logs.

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jan 15, 2019

@kjozwiak Issue logged earlier was generic for all the platform. Hence i have not added command.
Now, i have provided command along with screen shots for the issue which i am seeing on Windows

#2871 (comment)

@btlechowski
Copy link

btlechowski commented Jan 17, 2019

Re #2871 (comment) . I have investigated a bit more and it seems that I also lack some of the ads logs.
ads logs that I get in terminal are from: ads_service_impl.cc
ads logs that I do NOT get in terminal are from: ads_impl.cc

Interestingly
ads_service_impl.cc is part of brave-core and can be found in /components/brave_ads/browser/ads_service_impl.cc

ads_impl.cc is part of bat-native-ads and can be found in /src/ads_impl.cc

@tmancey
Copy link
Contributor

tmancey commented Jan 19, 2019

@btlechowski see https://www.chromium.org/for-testers/enable-logging as stderr cannot be redirected to the console for Windows, for logging you should use the following command-line arguments: --enable-logging=stderr --log-level=2

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@GeetaSarvadnya
Copy link
Author

As discussed with @tmancey over the zoom call, on Windows Chromium does not log to stderr. Inorder to check ads service logs we need to verify chrome_debug.log file.

Hence closing the issue as it works as expected.

@GeetaSarvadnya GeetaSarvadnya added this to the Dupe / Invalid / Not actionable milestone Feb 13, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants