Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same strings are displayed twice in some UI in korean locale #2868

Closed
simonhong opened this issue Jan 9, 2019 · 4 comments · Fixed by brave/brave-core#1366
Closed

Same strings are displayed twice in some UI in korean locale #2868

simonhong opened this issue Jan 9, 2019 · 4 comments · Fixed by brave/brave-core#1366

Comments

@simonhong
Copy link
Member

simonhong commented Jan 9, 2019

Description

Same strings are displayed twice in some UI in korean locale and <ex> string is attached.
2019-01-09 4 36 57
2019-01-09 4 37 31

This isn't happened in en locale.

Steps to Reproduce

  1. Visit chrome webstore
  2. Trying to install any extensions
  3. Check dialog displays extension name twice

Actual result:

dialog displays extension name twice

Expected result:

dialog title should not display extension name twice

Reproduces how often:

All

Brave version (brave://version info)

0.58.18 Chromium: 71.0.3578.98

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? No

Additional Information

cc: @rebron

@simonhong simonhong self-assigned this Jan 9, 2019
@simonhong simonhong added this to the 1.x Backlog milestone Jan 9, 2019
@simonhong
Copy link
Member Author

Should be updated in https://www.transifex.com/brave/brave

@simonhong
Copy link
Member Author

Updated in transifex.

@srirambv
Copy link
Contributor

@simonhong This is what I see on English as well. Similar to #2448
screenshot from 2019-01-24 12-40-13
image

The above screenshots are from

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Linux

@srirambv srirambv reopened this Jan 24, 2019
@srirambv
Copy link
Contributor

srirambv commented Jan 24, 2019

Verification passed on

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta (64 bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Linux

image

image

Verified passed with

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

screen shot 2019-01-24 at 12 47 37

screen shot 2019-01-24 at 12 48 14

Verification passed on:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta (64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows 10

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment