Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sardine description #28665

Closed
muliswilliam opened this issue Feb 22, 2023 · 2 comments · Fixed by brave/brave-core#17326
Closed

Update sardine description #28665

muliswilliam opened this issue Feb 22, 2023 · 2 comments · Fixed by brave/brave-core#17326
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@muliswilliam
Copy link

No description provided.

@muliswilliam muliswilliam converted this from a draft issue Feb 22, 2023
@muliswilliam muliswilliam self-assigned this Feb 22, 2023
@muliswilliam muliswilliam moved this from In Review to In Progress in Web3 Feb 22, 2023
@muliswilliam muliswilliam mentioned this issue Feb 22, 2023
Merged
25 tasks
@muliswilliam muliswilliam moved this from In Progress to Done in Web3 Feb 22, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 22, 2023
This was referenced Feb 27, 2023
Merged
Closed
@kjozwiak
Copy link
Member

The above requires 1.49.116 or higher for 1.49.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Mar 3, 2023

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Windows 11 Version 22H2 (Build 22621.755)

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Update sardine description brave/brave-core
4 participants
@kjozwiak @srirambv @brave-builds @muliswilliam