Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of search ad from the page fails on 1.49.x #28642

Closed
btlechowski opened this issue Feb 21, 2023 · 1 comment
Closed

Parsing of search ad from the page fails on 1.49.x #28642

btlechowski opened this issue Feb 21, 2023 · 1 comment

Comments

@btlechowski
Copy link

Not reproducible on 1.50.x

Steps to Reproduce

  1. Run Brave using (fucntionality is behind a flag):
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --enable-features=SupportBraveSearchResultAdConfirmationEvents

  1. Enable rewards and ads
  2. Trigger a search ad

Actual result:

Search ad was not parsed:

[5483:5483:0221/132910.968632:VERBOSE6:search_result_ad_converting_util.cc(239)] Some of search result ad attributes were not specified: data-conversion-advertiser-public-key-value, data-conversion-observation-window-value, data-conversion-type-value, data-conversion-url-pattern-value

Expected result:

Search ad was parsed:

[5146:5146:0221/132149.606688:VERBOSE6:search_result_ad_converting_util.cc(308)] A search result ad was delivered:
  "data-placement-id": 8307b888-cbe2-4ac8-ad98-4b8c92578094
  "data-creative-instance-id": dee04019-f32c-478e-9a9d-1861032bd268
  "data-creative-set-id": d3bb88f0-0814-4c8f-aebb-8eddc0604469
  "data-campaign-id": 5f8595c6-d25f-4786-aaa2-ce380ea8c6b5
  "data-advertiser-id": 735a260f-45d5-4b29-b2f0-9918e910f0ae
  "data-landing-page": https://med.etoro.com/aw.aspx?B=20017&A=84346&Task=Click&SubAffiliateID=352042739
  "data-headline-text": eToro™ - Multiple Asset Broker
  "data-description": Discover Opportunities in Local & Global Markets. Capital at risk. See PDS and TMD
  "data-rewards-value": 0

Reproduces how often:

Brave version (brave://version info)

Brave 1.49.106 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? no
@tmancey
Copy link
Contributor

tmancey commented Feb 27, 2023

Closing as fix was not uplifted. Thanks

@tmancey tmancey closed this as completed Feb 27, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants