Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Solana Swaps, you can make an order for funds you don't have #28623

Closed
HEagle18 opened this issue Feb 20, 2023 · 2 comments · Fixed by brave/brave-core#17312
Closed

On Solana Swaps, you can make an order for funds you don't have #28623

HEagle18 opened this issue Feb 20, 2023 · 2 comments · Fixed by brave/brave-core#17312
Assignees
Labels
bug feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include

Comments

@HEagle18
Copy link

Description

We let an order get created even though we know the user doesn't have that balance. Tested this flow on Uniswap, Matcha and Jup.ag and
Screenshot 2023-02-20 at 22 04 44
they didn't allow an user to create it.

Attached is screenshot
Screenshot 2023-02-20 at 21 58 29

Steps to Reproduce

  1. Select USDC to SOL
  2. Select more USDC than you have in your wallet
  3. Order gets created

Actual result:

Expected result:

It doesn't allow you to create this transaction

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/swap labels Feb 20, 2023
@HEagle18 HEagle18 added this to Web3 Feb 20, 2023
@onyb onyb added QA/Yes release-notes/include front-end-change This task is a front end task and doesn't need any C++ changes and removed OS/Android Fixes related to Android browser functionality labels Feb 21, 2023
@onyb onyb moved this to In Progress in Web3 Feb 21, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Feb 22, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 22, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2023

The above requires 1.49.118 or higher for 1.49.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Mar 3, 2023

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from issue description
  • Verified cannot place order on Solana Swap when there is no enough token balance
  • Verified Review order is disabled if the balance is insufficient
  • Verified Review order button changes to Insufficient XXX balance and is disabled preventing user to place order on a token without any balance
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants