Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer warning mentions Win 7 or higher rather than the expected Win 10 or higher for C110 #28511

Closed
kjozwiak opened this issue Feb 14, 2023 · 8 comments · Fixed by brave/brave-core#17234

Comments

@kjozwiak
Copy link
Member

Description

When attempting to install C110 on a Win 8.1 VM, you get a warning that states that Brave needs Win 7 or higher which is incorrect as the message should say Win 10 or higher due to C110 dropping support for both Win 7 & Win 8.

Steps to Reproduce

  1. download/install a .exe from https://github.com/brave/brave-browser/releases/tag/v1.48.162 on a Win 7 or Win 8 machine

Actual result:

Screenshot 2023-02-14 at 11 02 09 AM

Expected result:

Should say Brave requires Windows 10 or higher.

Reproduces how often:

100% reproducible using the STR/Cases outlined above.

Brave version (brave://version info)

Brave | 1.48.162 Chromium: 110.0.5481.97 (Official Build) (32-bit)
-- | --
Revision | d86ee9f656cd2fd313c1c1f12617008a1c3b571b-refs/branch-heads/5481_77@{#10}

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @btlechowski @mihaiplesa @mherrmann

@mherrmann mherrmann self-assigned this Feb 14, 2023
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 14, 2023
@mihaiplesa mihaiplesa changed the title installer warning mentions Win 7 or higher rather than the expected Win 10 or higher for C110 Installer warning mentions Win 7 or higher rather than the expected Win 10 or higher for C110 Feb 15, 2023
@mherrmann
Copy link

I can only reproduce this with the standalone installer. The online installer installs an older version of Brave that is still compatible with (in my case) Windows 7.

@btlechowski
Copy link

Reproduced with standalone installer 1.48.164. stub installer installs 1.47.x

image

@kjozwiak
Copy link
Member Author

I can only reproduce this with the standalone installer. The online installer installs an older version of Brave that is still compatible with (in my case) Windows 7.

@mherrmann yup, only reproducible with the standalone versions as you're trying to install an incompatible version. Stub installers correctly download the latest version that can run on Win 7 & Win 8 so no errors/issues.

@kjozwiak
Copy link
Member Author

kjozwiak commented Mar 8, 2023

The above requires 1.49.120 or higher for 1.49.x verification 👍 @brave/qa-team please note, that this only needs to be checked on Win 8 and Win 7. Maybe a quick spot check to makes sure that the Standalone executables are working without any issues on Win 11 & Win 10.

@btlechowski
Copy link

Verification passed on

Brave 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 7 Service Pack 1 (Build 7601.24544)

image

@btlechowski
Copy link

Verification passed on

Brave 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 8.1

image

@btlechowski
Copy link

Verification passed on

Brave 1.38.119 Chromium: 101.0.4951.67 (Official Build) (32-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 7 Service Pack 1 (Build 7601.24544)

x86x32
image

@btlechowski
Copy link

btlechowski commented Mar 8, 2023

Verification passed on

Brave 1.49.120 Chromium: 111.0.5563.64 (Official Build) (32-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 8.1 32bit

Also verified translations are applied

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants